ui/ozone/public/client_native_pixmap_factory_ozone.cc - Issue 2705333006: Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/ozone/public/client_native_pixmap_factory_ozone.cc

Issue 2705333006: Move client_native_pixmap_factory.h from ui/ozone/public to ui/gfx (Closed)

Patch Set: Add client_native_pixmap_factory_ozone.h Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/ozone/public/client_native_pixmap_factory_ozone.h"

	6

	7 #include "base/trace_event/trace_event.h"

	8 #include "ui/ozone/platform_object.h"

	9 #include "ui/ozone/platform_selection.h"

	10

	11 namespace ui {

	12

	13 std::unique_ptr<ClientNativePixmapFactory>
	rjkroege 2017/03/21 16:41:08 ah! Ignore my previous concern about where the tra ah! Ignore my previous concern about where the tracing went. Julien Isorce 2017/03/21 17:39:46 Thx for the review. I noticed that I should rename Show quoted text On 2017/03/21 16:41:08, rjkroege wrote: > ah! Ignore my previous concern about where the tracing went. Thx for the review. I noticed that I should rename "ClientNativePixmapFactory::Create" to "CreateClientNativePixmapFactoryOzone". I will upload the change.
	14 CreateClientNativePixmapFactoryOzone() {

	15 TRACE_EVENT1("ozone", "ClientNativePixmapFactory::Create", "platform",

	16 GetOzonePlatformName());

	17 return PlatformObject<ClientNativePixmapFactory>::Create();

	18 }

	19

	20 } // namespace ui

OLD	NEW