Add clean layout DCHECK to mostBackwardCaretPosition()

Add clean layout DCHECK to mostBackwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostBackwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostBackwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[1], which is for |mostForwardCaretPosition()|.

This patch also makes |VisibleSelection::toNormalizedEphemeralRange()| to
use |needsLayoutTreeUpdate()| since |Document::needsLayoutTreeUpdate()| returns
false for "editing/inserting/insert_html_as_plain_text.html".

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized positions
[2] http://crrev.com/2706163002 Add clean layout DCHECK to mostForwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2705113003
Cr-Commit-Position: refs/heads/master@{#451869}
Committed: https://chromium.googlesource.com/chromium/src/+/52407bff3797a14717d3bd8fcd5c0e3a56489640

[yosin_UTC9, 2017-02-21 08:43:23]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 08:43:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-21 09:12:01]

Description was changed from

==========
2017-02-21T17:42:08

2017-02-21T17:42:04

BUG=
==========

to

==========
Add clean layout DCHECK to mostBackwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostBackwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostBackwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[1], which is for |mostForwardCaretPosition()|

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2706163002 Add clean layout DCHECK to
mostForwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 09:14:01]

Description was changed from

==========
Add clean layout DCHECK to mostBackwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostBackwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostBackwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[1], which is for |mostForwardCaretPosition()|

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2706163002 Add clean layout DCHECK to
mostForwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes
==========

to

==========
Add clean layout DCHECK to mostBackwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostBackwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostBackwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[1], which is for |mostForwardCaretPosition()|.

This patch also makes |VisibleSelection::toNormalizedEphemeralRange()| to
use |needsLayoutTreeUpdate()| since |Document::needsLayoutTreeUpdate()| returns
false for "editing/inserting/insert_html_as_plain_text.html".

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2706163002 Add clean layout DCHECK to
mostForwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 09:14:39]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@google.com, yoichio@chromium.org

[yosin_UTC9, 2017-02-21 09:14:40]

PTAL

Please click [Commit] if it is OK to commit.
Thanks!

[commit-bot: I haz the power, 2017-02-21 11:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 11:19:54]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-21 22:55:52]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-21 22:55:52]

lgtm

[commit-bot: I haz the power, 2017-02-21 22:57:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:22:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487717752076270, "parent_rev":
"fd4cb6042b4a053db98e1e57309b8132e3274f26", "commit_rev":
"52407bff3797a14717d3bd8fcd5c0e3a56489640"}

[commit-bot: I haz the power, 2017-02-22 01:22:50]

Description was changed from

==========
Add clean layout DCHECK to mostBackwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostBackwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostBackwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[1], which is for |mostForwardCaretPosition()|.

This patch also makes |VisibleSelection::toNormalizedEphemeralRange()| to
use |needsLayoutTreeUpdate()| since |Document::needsLayoutTreeUpdate()| returns
false for "editing/inserting/insert_html_as_plain_text.html".

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2706163002 Add clean layout DCHECK to
mostForwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes
==========

to

==========
Add clean layout DCHECK to mostBackwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostBackwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostBackwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[1], which is for |mostForwardCaretPosition()|.

This patch also makes |VisibleSelection::toNormalizedEphemeralRange()| to
use |needsLayoutTreeUpdate()| since |Document::needsLayoutTreeUpdate()| returns
false for "editing/inserting/insert_html_as_plain_text.html".

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2706163002 Add clean layout DCHECK to
mostForwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2705113003
Cr-Commit-Position: refs/heads/master@{#451869}
Committed:
https://chromium.googlesource.com/chromium/src/+/52407bff3797a14717d3bd8fcd5c...
==========

[commit-bot: I haz the power, 2017-02-22 01:22:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/52407bff3797a14717d3bd8fcd5c...