Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2705113003: Add clean layout DCHECK to mostBackwardCaretPosition() (Closed)
Patch Set: 2017-02-21T17:42:08 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index 8d89792653f41418faea5f8a3e9a1dd4f115a4f3..575eb84fe4e258a1d999f714cd55bac82dee37f7 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -194,7 +194,7 @@ VisibleSelectionTemplate<Strategy>::toNormalizedEphemeralRange() const {
// in the course of running edit commands which modify the DOM.
// Failing to ensure this can result in equivalentXXXPosition calls returning
// incorrect results.
- DCHECK(!m_start.document()->needsLayoutTreeUpdate());
+ DCHECK(!needsLayoutTreeUpdate(m_start)) << *this;
if (isCaret()) {
// If the selection is a caret, move the range start upstream. This
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698