third_party/WebKit/Source/core/editing/VisibleUnits.cpp - Issue 2705113003: Add clean layout DCHECK to mostBackwardCaretPosition()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2705113003: Add clean layout DCHECK to mostBackwardCaretPosition() (Closed)

Patch Set: 2017-02-21T17:42:08 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

index d14f4be68350a5fc4d2e59c7b57edb9bdd8420d2..c06ed2fb4361ad15e1f502cbb9cd2e963f498dbc 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

@@ -2844,6 +2844,7 @@ template <typename Strategy>

static PositionTemplate<Strategy> mostBackwardCaretPosition(

const PositionTemplate<Strategy>& position,

EditingBoundaryCrossingRule rule) {

+ DCHECK(!needsLayoutTreeUpdate(position)) << position;

TRACE_EVENT0("input", "VisibleUnits::mostBackwardCaretPosition");

Node* startNode = position.anchorNode();