Chromium Code Reviews
DescriptionMerge "[NTP:Downloads] Request offline pages even if model is not ..."
This is a merge of https://codereview.chromium.org/2683383002 into M57
(branch 2987).
Previously another CL (https://codereview.chromium.org/2667073003) was
merged as well (see https://codereview.chromium.org/2706863002), in
order to avoid conflicts when merging this one.
There were no conflicts, both CLs has been tested on two devices and
unittests.
Original description:
Do not check whether Offline Pages model has been loaded when requesting
offline pages. Currently the model simply collects all requests and
answers them when it is loaded. In this CL Downloads provider waits for
the model to answer instead of not showing offline pages on startup.
BUG=690391
Review-Url: https://codereview.chromium.org/2683383002
Cr-Commit-Position: refs/heads/master@{#449603}
(cherry picked from commit 600636adf773150653cf033c94649a75f7d3b2fb)
Review-Url: https://codereview.chromium.org/2704203002 .
Cr-Commit-Position: refs/branch-heads/2987@{#598}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/58ecbe8cb269156ac6fd6c30c837bd8d918e9b2a
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||