Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2704203002: Merge "[NTP:Downloads] Request offline pages even if model is not ..." (Closed)

Created:
3 years, 10 months ago by vitaliii
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Merge "[NTP:Downloads] Request offline pages even if model is not ..." This is a merge of https://codereview.chromium.org/2683383002 into M57 (branch 2987). Previously another CL (https://codereview.chromium.org/2667073003) was merged as well (see https://codereview.chromium.org/2706863002), in order to avoid conflicts when merging this one. There were no conflicts, both CLs has been tested on two devices and unittests. Original description: Do not check whether Offline Pages model has been loaded when requesting offline pages. Currently the model simply collects all requests and answers them when it is loaded. In this CL Downloads provider waits for the model to answer instead of not showing offline pages on startup. BUG=690391 Review-Url: https://codereview.chromium.org/2683383002 Cr-Commit-Position: refs/heads/master@{#449603} (cherry picked from commit 600636adf773150653cf033c94649a75f7d3b2fb) Review-Url: https://codereview.chromium.org/2704203002 . Cr-Commit-Position: refs/branch-heads/2987@{#598} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/58ecbe8cb269156ac6fd6c30c837bd8d918e9b2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M chrome/browser/ntp_snippets/download_suggestions_provider.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vitaliii
3 years, 10 months ago (2017-02-20 15:28:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58ecbe8cb269156ac6fd6c30c837bd8d918e9b2a.

Powered by Google App Engine
This is Rietveld 408576698