Revert of Add PrefStore::GetValues

Revert of Add PrefStore::GetValues (patchset #8 id:140001 of https://codereview.chromium.org/2692203007/ )

Reason for revert:
Breaks compile on Cronet proxy.

BUG=694814
Original issue's description:
> Add PrefStore::GetValues
> 
> Currently there's no way to proxy a PrefStore, which we need to
> in the new prefs service, because there's no way to get its
> initial state. The existing observer interface can only be used
> to get changed values and GetValue requires that you know all the
> keys in advance.
> 
> GetValues involve a deep copy, but the intended consumer needs to
> take ownership to send the value over the wire anyway.
> 
> Design doc: https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkcTY/edit?usp=sharing
> 
> BUG=654988
> 
> Review-Url: https://codereview.chromium.org/2692203007
> Cr-Commit-Position: refs/heads/master@{#451691}
> Committed: https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b19ee58a5a4b06

TBR=sammc@chromium.org,emaxx@chromium.org,bauerb@chromium.org,tibell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=654988
Review-Url: https://codereview.chromium.org/2704133006
Cr-Commit-Position: refs/heads/master@{#451856}
Committed: https://chromium.googlesource.com/chromium/src/+/0373fe1947fb05fbe421407dc7f393e430db6019

[aelias_OOO_until_Jul13, 2017-02-21 23:48:40]

The CQ bit was checked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2017-02-21 23:48:40]

Created Revert of Add PrefStore::GetValues

[commit-bot: I haz the power, 2017-02-21 23:49:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:51:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487720920483250, "parent_rev":
"680838dbb7a482010ffa8c686245ddc2de024e45", "commit_rev":
"0373fe1947fb05fbe421407dc7f393e430db6019"}

[commit-bot: I haz the power, 2017-02-21 23:51:43]

Description was changed from

==========
Revert of Add PrefStore::GetValues (patchset #8 id:140001 of
https://codereview.chromium.org/2692203007/ )

Reason for revert:
Breaks compile on Cronet proxy.

BUG=694814

Original issue's description:
> Add PrefStore::GetValues
> 
> Currently there's no way to proxy a PrefStore, which we need to
> in the new prefs service, because there's no way to get its
> initial state. The existing observer interface can only be used
> to get changed values and GetValue requires that you know all the
> keys in advance.
> 
> GetValues involve a deep copy, but the intended consumer needs to
> take ownership to send the value over the wire anyway.
> 
> Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...
> 
> BUG=654988
> 
> Review-Url: https://codereview.chromium.org/2692203007
> Cr-Commit-Position: refs/heads/master@{#451691}
> Committed:
https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b1...

TBR=sammc@chromium.org,emaxx@chromium.org,bauerb@chromium.org,tibell@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=654988
==========

to

==========
Revert of Add PrefStore::GetValues (patchset #8 id:140001 of
https://codereview.chromium.org/2692203007/ )

Reason for revert:
Breaks compile on Cronet proxy.

BUG=694814

Original issue's description:
> Add PrefStore::GetValues
> 
> Currently there's no way to proxy a PrefStore, which we need to
> in the new prefs service, because there's no way to get its
> initial state. The existing observer interface can only be used
> to get changed values and GetValue requires that you know all the
> keys in advance.
> 
> GetValues involve a deep copy, but the intended consumer needs to
> take ownership to send the value over the wire anyway.
> 
> Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...
> 
> BUG=654988
> 
> Review-Url: https://codereview.chromium.org/2692203007
> Cr-Commit-Position: refs/heads/master@{#451691}
> Committed:
https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b1...

TBR=sammc@chromium.org,emaxx@chromium.org,bauerb@chromium.org,tibell@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=654988

Review-Url: https://codereview.chromium.org/2704133006
Cr-Commit-Position: refs/heads/master@{#451856}
Committed:
https://chromium.googlesource.com/chromium/src/+/0373fe1947fb05fbe421407dc7f3...
==========

[commit-bot: I haz the power, 2017-02-21 23:51:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0373fe1947fb05fbe421407dc7f3...

[tibell, 2017-02-21 23:51:56]

On 2017/02/21 23:48:40, aelias wrote:
> Created Revert of Add PrefStore::GetValues

Could you please link to the failure when reverting so we can address them? Is
the thing that broke on the CQ?

[aelias_OOO_until_Jul13, 2017-02-21 23:54:16]

The failure is linked on the bug http://crbug.com/694814.  It seems not to be on
the CQ but is marked as tree closer on Android sheriff-o-matic
https://sheriff-o-matic.appspot.com/android# .  (That seems nonideal but don't
blame me, I'm just the sheriff today.)