Add PrefStore::GetValues

Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc: https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkcTY/edit?usp=sharing

BUG=654988
Review-Url: https://codereview.chromium.org/2692203007
Cr-Commit-Position: refs/heads/master@{#451691}
Committed: https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b19ee58a5a4b06
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2692203007
Cr-Commit-Position: refs/heads/master@{#452336}
Committed: https://chromium.googlesource.com/chromium/src/+/e23659b47bf9f47507986faba38b70aa10ca8497

[tibell, 2017-02-15 23:34:29]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 23:35:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 01:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:39:51]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[tibell, 2017-02-16 01:55:58]

tibell@chromium.org changed reviewers:
+ jam@chromium.org, sammc@chromium.org

[tibell, 2017-02-16 01:55:59]

This will be used for prefs. I had an alternative implementation using a
type-erased iterator, but that turned out quite a bit more complex than
returning a copy. In the end we need a copy anyway for the Mojo layer.

[tibell, 2017-02-16 02:00:28]

On 2017/02/16 01:55:59, tibell wrote:
> This will be used for prefs. I had an alternative implementation using a
> type-erased iterator, but that turned out quite a bit more complex than
> returning a copy. In the end we need a copy anyway for the Mojo layer.

Used in https://codereview.chromium.org/2635153002/ and
https://codereview.chromium.org/2601873002/.

[Sam McNally, 2017-02-16 02:21:11]

https://codereview.chromium.org/2692203007/diff/1/components/prefs/overlay_us...
File components/prefs/overlay_user_pref_store.cc (right):

https://codereview.chromium.org/2692203007/diff/1/components/prefs/overlay_us...
components/prefs/overlay_user_pref_store.cc:55: const std::string overlay_key =
GetOverlayKey(underlay_iter.key());
const std::string&

https://codereview.chromium.org/2692203007/diff/1/components/prefs/pref_store.h
File components/prefs/pref_store.h (right):

https://codereview.chromium.org/2692203007/diff/1/components/prefs/pref_store...
components/prefs/pref_store.h:8: #include <iterator>
<memory>?

https://codereview.chromium.org/2692203007/diff/1/components/user_prefs/track...
File components/user_prefs/tracked/segregated_pref_store.cc (right):

https://codereview.chromium.org/2692203007/diff/1/components/user_prefs/track...
components/user_prefs/tracked/segregated_pref_store.cc:87: auto selected_values
= selected_pref_store_->GetValues();
These should use the selected store for keys (with expansion) in
|selected_preference_names_| and the default store for others.

[tibell, 2017-02-20 00:04:18]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 00:04:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tibell, 2017-02-20 00:04:56]

tibell@chromium.org changed reviewers:
- jam@chromium.org

[tibell, 2017-02-20 00:04:58]

PTAL

https://codereview.chromium.org/2692203007/diff/1/components/prefs/overlay_us...
File components/prefs/overlay_user_pref_store.cc (right):

https://codereview.chromium.org/2692203007/diff/1/components/prefs/overlay_us...
components/prefs/overlay_user_pref_store.cc:55: const std::string overlay_key =
GetOverlayKey(underlay_iter.key());
On 2017/02/16 02:21:11, Sam McNally wrote:
> const std::string&

Done.

https://codereview.chromium.org/2692203007/diff/1/components/prefs/pref_store.h
File components/prefs/pref_store.h (right):

https://codereview.chromium.org/2692203007/diff/1/components/prefs/pref_store...
components/prefs/pref_store.h:8: #include <iterator>
On 2017/02/16 02:21:11, Sam McNally wrote:
> <memory>?

Done.

https://codereview.chromium.org/2692203007/diff/1/components/user_prefs/track...
File components/user_prefs/tracked/segregated_pref_store.cc (right):

https://codereview.chromium.org/2692203007/diff/1/components/user_prefs/track...
components/user_prefs/tracked/segregated_pref_store.cc:87: auto selected_values
= selected_pref_store_->GetValues();
On 2017/02/16 02:21:11, Sam McNally wrote:
> These should use the selected store for keys (with expansion) in
> |selected_preference_names_| and the default store for others.

Done.

[Sam McNally, 2017-02-20 00:31:11]

lgtm

https://codereview.chromium.org/2692203007/diff/20001/components/prefs/pref_s...
File components/prefs/pref_store.h (right):

https://codereview.chromium.org/2692203007/diff/20001/components/prefs/pref_s...
components/prefs/pref_store.h:57: // Get all the values.
Document whether this can return null.

[commit-bot: I haz the power, 2017-02-20 02:10:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 02:10:53]

Dry run: This issue passed the CQ dry run.

[tibell, 2017-02-20 02:54:08]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 02:54:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tibell, 2017-02-20 02:56:40]

Description was changed from

==========
Add PrefStore::GetValues

Currently no way to proxy a PrefStore, which we need to in the new prefs
service, because there's no way to get its initial state. The existing observer
interface can only be used to get changed values and GetValue requires that you
know all the keys in advance.

GetValues involve a deep copy, but the intended consumer needs to take ownership
to send the value over the wire anyway.

BUG=654988
==========

to

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

BUG=654988
==========

[tibell, 2017-02-20 02:59:50]

tibell@chromium.org changed reviewers:
+ bauerb@chromium.org, emaxx@chromium.org

[tibell, 2017-02-20 02:59:51]

emaxx@chromium.org: Please review changes in
components/policy/core/browser/configuration_policy_pref_store.h

bauerb@chromium.org: Please review remaining changes

This change is used in the effort to convert prefs into a service. These CLs
depend on this one:

https://codereview.chromium.org/2635153002/
https://codereview.chromium.org/2601873002/

[tibell, 2017-02-20 03:04:20]

Document GetValues better

[tibell, 2017-02-20 03:04:22]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 03:04:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tibell, 2017-02-20 03:05:09]

https://codereview.chromium.org/2692203007/diff/20001/components/prefs/pref_s...
File components/prefs/pref_store.h (right):

https://codereview.chromium.org/2692203007/diff/20001/components/prefs/pref_s...
components/prefs/pref_store.h:57: // Get all the values.
On 2017/02/20 00:31:11, Sam McNally wrote:
> Document whether this can return null.

Done.

[commit-bot: I haz the power, 2017-02-20 03:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 03:29:05]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tibell, 2017-02-20 04:42:59]

Fix path expansion in unit tests

[tibell, 2017-02-20 04:43:01]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 04:43:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 06:06:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 06:06:42]

Dry run: This issue passed the CQ dry run.

[emaxx, 2017-02-20 14:03:57]

LGTM components/policy/core/browser/configuration_policy_pref_store.*

[Bernhard Bauer, 2017-02-20 14:14:45]

LGTM

Is there a design doc for this? I'm getting a vague idea from
https://codereview.chromium.org/2635153002/, but a bit more detail would be
nice. I assume we make copies of all the values to allow synchronously reading
them (whereas Mojo only allows asynchronous)? I'm mostly thinking out loud here,
but I'm wondering whether what we want isn't actually a service with an API
similar to PrefService (which doesn't work, because async), but rather a service
that can update a set of PrefStores if the underlying data changes...? Again,
design doc would be awesome here :)

[tibell, 2017-02-20 23:19:55]

Description was changed from

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

BUG=654988
==========

to

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/a/chromium.org/document/d/1BezuCCGzi4-zbKcXjEN6BSob7R...

BUG=654988
==========

[tibell, 2017-02-20 23:26:16]

On 2017/02/20 14:14:45, Bernhard Bauer wrote:
> LGTM
> 
> Is there a design doc for this? I'm getting a vague idea from
> https://codereview.chromium.org/2635153002/, but a bit more detail would be
> nice. I assume we make copies of all the values to allow synchronously reading
> them (whereas Mojo only allows asynchronous)? I'm mostly thinking out loud
here,
> but I'm wondering whether what we want isn't actually a service with an API
> similar to PrefService (which doesn't work, because async), but rather a
service
> that can update a set of PrefStores if the underlying data changes...? Again,
> design doc would be awesome here :)

I've added a link to our initial design doc. We've now done some more thinking
so it needs to be expanded upon, but the basic idea is this:

 * We need to offer a sync API for reading/writing prefs as there are currently
1,300 sync readers/writers in Chrome.
 * We do this by offering a client lib that caches prefs.
 * This client lib is essentially the C++ PrefService with 1) all its pref
stores replaced by Mojo ones that talk to a backend asynchronously and 2) a
cache.

There are more details regarding who owns which pref keys, etc in the future,
but this is the basic design.

[tibell, 2017-02-20 23:52:30]

Description was changed from

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/a/chromium.org/document/d/1BezuCCGzi4-zbKcXjEN6BSob7R...

BUG=654988
==========

to

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...

BUG=654988
==========

[tibell, 2017-02-21 01:51:09]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 01:51:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tibell, 2017-02-21 01:52:13]

sammc@chromium.org: I fixed an issue with expanded keys and updated the tests to
reflect. Could you please double-check before I submit? Thanks!

[Sam McNally, 2017-02-21 01:58:26]

https://codereview.chromium.org/2692203007/diff/100001/components/prefs/overl...
File components/prefs/overlay_user_pref_store.cc (right):

https://codereview.chromium.org/2692203007/diff/100001/components/prefs/overl...
components/prefs/overlay_user_pref_store.cc:55: const std::string& underlay_key
= overlay_mapping.first;
second

https://codereview.chromium.org/2692203007/diff/100001/components/prefs/overl...
components/prefs/overlay_user_pref_store.cc:60: if (values->Remove(underlay_key,
&out_value)) {
Merge this into the else if?

https://codereview.chromium.org/2692203007/diff/100001/components/prefs/overl...
File components/prefs/overlay_user_pref_store_unittest.cc (right):

https://codereview.chromium.org/2692203007/diff/100001/components/prefs/overl...
components/prefs/overlay_user_pref_store_unittest.cc:316: // To check merge
behavior, create underlay and overlay so each has a key the
Can you test with mapped_overlay_key and mapped_underlay_key?

[tibell, 2017-02-21 02:10:22]

Correctly ignore underlay values with different keys and add test for this

[tibell, 2017-02-21 02:10:24]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 02:10:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tibell, 2017-02-21 02:11:07]

PTAL

https://codereview.chromium.org/2692203007/diff/100001/components/prefs/overl...
File components/prefs/overlay_user_pref_store.cc (right):

https://codereview.chromium.org/2692203007/diff/100001/components/prefs/overl...
components/prefs/overlay_user_pref_store.cc:55: const std::string& underlay_key
= overlay_mapping.first;
On 2017/02/21 01:58:25, Sam McNally wrote:
> second

Done.

https://codereview.chromium.org/2692203007/diff/100001/components/prefs/overl...
components/prefs/overlay_user_pref_store.cc:60: if (values->Remove(underlay_key,
&out_value)) {
On 2017/02/21 01:58:25, Sam McNally wrote:
> Merge this into the else if?

Done.

Reordered things to remove some if-statement nesting.

https://codereview.chromium.org/2692203007/diff/100001/components/prefs/overl...
File components/prefs/overlay_user_pref_store_unittest.cc (right):

https://codereview.chromium.org/2692203007/diff/100001/components/prefs/overl...
components/prefs/overlay_user_pref_store_unittest.cc:316: // To check merge
behavior, create underlay and overlay so each has a key the
On 2017/02/21 01:58:25, Sam McNally wrote:
> Can you test with mapped_overlay_key and mapped_underlay_key?

Done.

[Sam McNally, 2017-02-21 02:12:13]

lgtm

https://codereview.chromium.org/2692203007/diff/120001/components/prefs/overl...
File components/prefs/overlay_user_pref_store_unittest.cc (right):

https://codereview.chromium.org/2692203007/diff/120001/components/prefs/overl...
components/prefs/overlay_user_pref_store_unittest.cc:350:
ASSERT_FALSE(values->Get(mapped_underlay_key, &value));
This one can be EXPECT_FALSE.

[tibell, 2017-02-21 02:16:45]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 02:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tibell, 2017-02-21 02:18:22]

https://codereview.chromium.org/2692203007/diff/120001/components/prefs/overl...
File components/prefs/overlay_user_pref_store_unittest.cc (right):

https://codereview.chromium.org/2692203007/diff/120001/components/prefs/overl...
components/prefs/overlay_user_pref_store_unittest.cc:350:
ASSERT_FALSE(values->Get(mapped_underlay_key, &value));
On 2017/02/21 02:12:13, Sam McNally wrote:
> This one can be EXPECT_FALSE.

Done.

[tibell, 2017-02-21 02:19:11]

The CQ bit was checked by tibell@chromium.org

[tibell, 2017-02-21 02:19:11]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
emaxx@chromium.org, sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/2692203007/#ps140001
(title: "Change ASSERT to EXPECT in test")

[commit-bot: I haz the power, 2017-02-21 02:19:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 03:22:28]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1487643551298880,
"parent_rev": "0402e8c9dd194fd74dce5eccf6b65cae62ae7847", "commit_rev":
"311d4a192239299e42e66b1319b19ee58a5a4b06"}

[commit-bot: I haz the power, 2017-02-21 03:23:05]

Description was changed from

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...

BUG=654988
==========

to

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...

BUG=654988

Review-Url: https://codereview.chromium.org/2692203007
Cr-Commit-Position: refs/heads/master@{#451691}
Committed:
https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b1...
==========

[commit-bot: I haz the power, 2017-02-21 03:23:06]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b1...

[aelias_OOO_until_Jul13, 2017-02-21 23:48:40]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2704133006/ by aelias@chromium.org.

The reason for reverting is: Breaks compile on Cronet proxy.

BUG=694814.

[tibell, 2017-02-22 03:26:29]

Description was changed from

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...

BUG=654988

Review-Url: https://codereview.chromium.org/2692203007
Cr-Commit-Position: refs/heads/master@{#451691}
Committed:
https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b1...
==========

to

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...

BUG=654988

Review-Url: https://codereview.chromium.org/2692203007
Cr-Commit-Position: refs/heads/master@{#451691}
Committed:
https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b1...
==========

[tibell, 2017-02-22 05:39:08]

Merge

[tibell, 2017-02-22 05:49:20]

Description was changed from

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...

BUG=654988

Review-Url: https://codereview.chromium.org/2692203007
Cr-Commit-Position: refs/heads/master@{#451691}
Committed:
https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b1...
==========

to

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...

BUG=654988

Review-Url: https://codereview.chromium.org/2692203007
Cr-Commit-Position: refs/heads/master@{#451691}
Committed:
https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b1...
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tibell, 2017-02-22 05:49:23]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 05:50:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tibell, 2017-02-22 05:55:28]

Add GetValues to FilesystemJsonPrefStore

[tibell, 2017-02-22 05:55:34]

The CQ bit was checked by tibell@chromium.org to run a CQ dry run

[tibell, 2017-02-22 05:56:41]

I've added implementations of GetValues for the two pref stores that weren't on
the CQ (see patch set 10 & 11). Can someone take a quick peek so I didn't mess
something up before submitting again?

[commit-bot: I haz the power, 2017-02-22 05:56:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-02-22 06:13:54]

lgtm

[tibell, 2017-02-22 06:16:09]

tibell@chromium.org changed reviewers:
+ erg@chromium.org, mgersh@chromium.org

[tibell, 2017-02-22 06:16:10]

mgersh@chromium.org: please review changes in components/cronet/android

erg@chromium.org: please review changes in components/filesystem

[commit-bot: I haz the power, 2017-02-22 07:43:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 07:43:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mgersh, 2017-02-22 15:34:12]

components/cronet/ lgtm

[Elliot Glaysher, 2017-02-22 18:29:32]

lgtm

[tibell, 2017-02-22 23:35:18]

The CQ bit was checked by tibell@chromium.org

[tibell, 2017-02-22 23:35:18]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
emaxx@chromium.org
Link to the patchset: https://codereview.chromium.org/2692203007/#ps190001
(title: "Add GetValues to FilesystemJsonPrefStore")

[commit-bot: I haz the power, 2017-02-22 23:35:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 01:44:18]

CQ is committing da patch.

Bot data: {"patchset_id": 190001, "attempt_start_ts": 1487806518324230,
"parent_rev": "3aeb76a311e61823dd4d6602bd0c213be085aba9", "commit_rev":
"e23659b47bf9f47507986faba38b70aa10ca8497"}

[commit-bot: I haz the power, 2017-02-23 01:45:06]

Description was changed from

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...

BUG=654988

Review-Url: https://codereview.chromium.org/2692203007
Cr-Commit-Position: refs/heads/master@{#451691}
Committed:
https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b1...
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Add PrefStore::GetValues

Currently there's no way to proxy a PrefStore, which we need to
in the new prefs service, because there's no way to get its
initial state. The existing observer interface can only be used
to get changed values and GetValue requires that you know all the
keys in advance.

GetValues involve a deep copy, but the intended consumer needs to
take ownership to send the value over the wire anyway.

Design doc:
https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkc...

BUG=654988

Review-Url: https://codereview.chromium.org/2692203007
Cr-Commit-Position: refs/heads/master@{#451691}
Committed:
https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b1...
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2692203007
Cr-Commit-Position: refs/heads/master@{#452336}
Committed:
https://chromium.googlesource.com/chromium/src/+/e23659b47bf9f47507986faba38b...
==========

[commit-bot: I haz the power, 2017-02-23 01:45:08]

Committed patchset #11 (id:190001) as
https://chromium.googlesource.com/chromium/src/+/e23659b47bf9f47507986faba38b...