Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: components/user_prefs/tracked/segregated_pref_store.cc

Issue 2704133006: Revert of Add PrefStore::GetValues (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_prefs/tracked/segregated_pref_store.cc
diff --git a/components/user_prefs/tracked/segregated_pref_store.cc b/components/user_prefs/tracked/segregated_pref_store.cc
index 297e2a7e58fa6c8cdcb0d0cfafc2120d9b7bd69c..edb1f2059920bb22706c69c36d2aea5f38fbe3e0 100644
--- a/components/user_prefs/tracked/segregated_pref_store.cc
+++ b/components/user_prefs/tracked/segregated_pref_store.cc
@@ -81,20 +81,6 @@
bool SegregatedPrefStore::GetValue(const std::string& key,
const base::Value** result) const {
return StoreForKey(key)->GetValue(key, result);
-}
-
-std::unique_ptr<base::DictionaryValue> SegregatedPrefStore::GetValues() const {
- auto values = default_pref_store_->GetValues();
- auto selected_pref_store_values = selected_pref_store_->GetValues();
- for (const auto& key : selected_preference_names_) {
- const base::Value* value = nullptr;
- if (selected_pref_store_values->Get(key, &value)) {
- values->Set(key, value->CreateDeepCopy());
- } else {
- values->Remove(key, nullptr);
- }
- }
- return values;
}
void SegregatedPrefStore::SetValue(const std::string& key,
« no previous file with comments | « components/user_prefs/tracked/segregated_pref_store.h ('k') | components/user_prefs/tracked/segregated_pref_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698