Associate Location with DOMWindow instead of Frame.

Associate Location with DOMWindow instead of Frame.

BUG=694111
Review-Url: https://codereview.chromium.org/2704133002
Cr-Commit-Position: refs/heads/master@{#451603}
Committed: https://chromium.googlesource.com/chromium/src/+/ad0db3749c27fd3c427f32d4c75d782540b40fba

[dcheng, 2017-02-20 05:48:50]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 05:49:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 07:47:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 07:47:25]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-02-20 08:32:58]

dcheng@chromium.org changed reviewers:
+ haraken@chromium.org, yukishiino@chromium.org

[dcheng, 2017-02-20 08:32:58]

https://codereview.chromium.org/2704133002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Location.cpp (left):

https://codereview.chromium.org/2704133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Location.cpp:143: if (!m_frame)
I opted to move these checks all into setLocation(), so we can centralize the
checking in one place.

[Yuki, 2017-02-20 08:57:47]

LGTM.

https://codereview.chromium.org/2704133002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Location.h (right):

https://codereview.chromium.org/2704133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Location.h:60: DOMWindow* window() const {
return m_domWindow.get(); }
nit: Document, Frame, ScriptState and ContextLifecycleObserver name it
|domWindow()|.

https://codereview.chromium.org/2704133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Location.h:130: // Note: it is only valid
to call this when this is a Location object is for a
maybe typo?: s/is for/for/

[dcheng, 2017-02-20 09:22:56]

https://codereview.chromium.org/2704133002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Location.h (right):

https://codereview.chromium.org/2704133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Location.h:60: DOMWindow* window() const {
return m_domWindow.get(); }
On 2017/02/20 08:57:46, Yuki wrote:
> nit: Document, Frame, ScriptState and ContextLifecycleObserver name it
> |domWindow()|.

Good point, done.

https://codereview.chromium.org/2704133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Location.h:130: // Note: it is only valid
to call this when this is a Location object is for a
On 2017/02/20 08:57:47, Yuki wrote:
> maybe typo?: s/is for/for/

Done.

[dcheng, 2017-02-20 09:23:53]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2017-02-20 09:23:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2704133002/#ps20001
(title: "fix typos, consistent naming")

[commit-bot: I haz the power, 2017-02-20 09:24:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-20 09:31:51]

LGTM

https://codereview.chromium.org/2704133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Location.h (right):

https://codereview.chromium.org/2704133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Location.h:136: // (2) and the frame is
attached.

What's a difference between (1) and (2)?

Or why is only (1) (i.e., m_domWindow->frame()) not enough?

[dcheng, 2017-02-20 09:36:00]

https://codereview.chromium.org/2704133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Location.h (right):

https://codereview.chromium.org/2704133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Location.h:136: // (2) and the frame is
attached.
On 2017/02/20 09:31:51, haraken wrote:
> 
> What's a difference between (1) and (2)?
> 
> Or why is only (1) (i.e., m_domWindow->frame()) not enough?

Hmm... I think you're right that (1) might be enough. I got confused because I
was trying to make sure I preserved existing semantics: the original
setLocation() method checked that m_frame->host() is not null.

However, I forgot that when we call LocalFrame::detach now, we call
frameDestroyed(), which will clear DOMWindow's frame pointer back to the frame:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Loc...

Is it OK to try fixing this in a followup, just in case there is a subtle
difference that I missed?

[dcheng, 2017-02-20 09:36:06]

The CQ bit was unchecked by dcheng@chromium.org

[haraken, 2017-02-20 09:36:53]

On 2017/02/20 09:36:00, dcheng wrote:
>
https://codereview.chromium.org/2704133002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/frame/Location.h (right):
> 
>
https://codereview.chromium.org/2704133002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/frame/Location.h:136: // (2) and the frame is
> attached.
> On 2017/02/20 09:31:51, haraken wrote:
> > 
> > What's a difference between (1) and (2)?
> > 
> > Or why is only (1) (i.e., m_domWindow->frame()) not enough?
> 
> Hmm... I think you're right that (1) might be enough. I got confused because I
> was trying to make sure I preserved existing semantics: the original
> setLocation() method checked that m_frame->host() is not null.
> 
> However, I forgot that when we call LocalFrame::detach now, we call
> frameDestroyed(), which will clear DOMWindow's frame pointer back to the
frame:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Loc...
> 
> Is it OK to try fixing this in a followup, just in case there is a subtle
> difference that I missed?

Sure.

[dcheng, 2017-02-20 09:39:50]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2017-02-20 09:40:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 10:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 10:41:03]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dcheng, 2017-02-20 10:45:37]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2017-02-20 10:46:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 12:15:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487587537635080,
"parent_rev": "9b6abde6cad9c609e4961e2149aafd328bfa19a5", "commit_rev":
"ad0db3749c27fd3c427f32d4c75d782540b40fba"}

[commit-bot: I haz the power, 2017-02-20 12:16:16]

Description was changed from

==========
Associate Location with DOMWindow instead of Frame.

BUG=694111
==========

to

==========
Associate Location with DOMWindow instead of Frame.

BUG=694111

Review-Url: https://codereview.chromium.org/2704133002
Cr-Commit-Position: refs/heads/master@{#451603}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad0db3749c27fd3c427f32d4c75d...
==========

[commit-bot: I haz the power, 2017-02-20 12:16:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ad0db3749c27fd3c427f32d4c75d...