third_party/WebKit/Source/core/frame/Frame.cpp - Issue 2704133002: Associate Location with DOMWindow instead of Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Frame.cpp

Issue 2704133002: Associate Location with DOMWindow instead of Frame. (Closed)

Patch Set: fix typos, consistent naming Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Frame.cpp

diff --git a/third_party/WebKit/Source/core/frame/Frame.cpp b/third_party/WebKit/Source/core/frame/Frame.cpp

index 36729ad46393f405d1d0a128f320b3bc3125a1e4..088d8401f448e15a1ef0f971e51d5bbc7c6bdd70 100644

--- a/third_party/WebKit/Source/core/frame/Frame.cpp

+++ b/third_party/WebKit/Source/core/frame/Frame.cpp

@@ -72,7 +72,6 @@ DEFINE_TRACE(Frame) {

void Frame::detach(FrameDetachType type) {

ASSERT(m_client);

m_client->setOpener(0);

- domWindow()->resetLocation();

disconnectOwnerElement();

// After this, we must no longer talk to the client since this clears

// its owning reference back to our owning LocalFrame.