Associate Location with DOMWindow instead of Frame.

third_party/WebKit/Source/core/frame/Location.cpp

 /*
  * Copyright (C) 2008, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 16 matching lines @@
  */
 
 #include "core/frame/Location.h"
 
 #include "bindings/core/v8/BindingSecurity.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/V8DOMActivityLogger.h"
 #include "core/dom/DOMURLUtilsReadOnly.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
+#include "core/frame/DOMWindow.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/loader/FrameLoader.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/SecurityOrigin.h"
 
 namespace blink {
 
-Location::Location(Frame* frame) : m_frame(frame) {}
+Location::Location(DOMWindow* domWindow) : m_domWindow(domWindow) {}
 
 DEFINE_TRACE(Location) {
-  visitor->trace(m_frame);
+  visitor->trace(m_domWindow);
 }
 
 inline const KURL& Location::url() const {
-  const KURL& url = toLocalFrame(m_frame)->document()->url();
+  const KURL& url = document()->url();
   if (!url.isValid()) {
     // Use "about:blank" while the page is still loading (before we have a
     // frame).
     return blankURL();
   }
 
   return url;
 }
 
 String Location::href() const {
-  if (!m_frame)
-    return String();
-
   return url().strippedForUseAsHref();
 }
 
 String Location::protocol() const {
-  if (!m_frame)
-    return String();
   return DOMURLUtilsReadOnly::protocol(url());
 }
 
 String Location::host() const {
-  if (!m_frame)
-    return String();
   return DOMURLUtilsReadOnly::host(url());
 }
 
 String Location::hostname() const {
-  if (!m_frame)
-    return String();
   return DOMURLUtilsReadOnly::hostname(url());
 }
 
 String Location::port() const {
-  if (!m_frame)
-    return String();
   return DOMURLUtilsReadOnly::port(url());
 }
 
 String Location::pathname() const {
-  if (!m_frame)
-    return String();
   return DOMURLUtilsReadOnly::pathname(url());
 }
 
 String Location::search() const {
-  if (!m_frame)
-    return String();
   return DOMURLUtilsReadOnly::search(url());
 }
 
 String Location::origin() const {
-  if (!m_frame)
-    return String();
   return DOMURLUtilsReadOnly::origin(url());
 }
 
 DOMStringList* Location::ancestorOrigins() const {
   DOMStringList* origins = DOMStringList::create();
-  if (!m_frame)
+  if (!isAttached())
     return origins;
-  for (Frame* frame = m_frame->tree().parent(); frame;
+  for (Frame* frame = m_domWindow->frame()->tree().parent(); frame;
        frame = frame->tree().parent()) {
     origins->append(frame->securityContext()->getSecurityOrigin()->toString());
   }
   return origins;
 }
 
 String Location::hash() const {
-  if (!m_frame)
-    return String();
-
   return DOMURLUtilsReadOnly::hash(url());
 }
 
 void Location::setHref(LocalDOMWindow* currentWindow,
                        LocalDOMWindow* enteredWindow,
                        const String& url,
                        ExceptionState& exceptionState) {
-  if (!m_frame)
-    return;
   setLocation(url, currentWindow, enteredWindow, &exceptionState);
 }
 
 void Location::setProtocol(LocalDOMWindow* currentWindow,
                            LocalDOMWindow* enteredWindow,
                            const String& protocol,
                            ExceptionState& exceptionState) {
-  if (!m_frame)
-    return;
-  KURL url = toLocalFrame(m_frame)->document()->url();
+  KURL url = document()->url();
   if (!url.setProtocol(protocol)) {
     exceptionState.throwDOMException(
         SyntaxError, "'" + protocol + "' is an invalid protocol.");
     return;
   }
   setLocation(url.getString(), currentWindow, enteredWindow, &exceptionState);
 }
 
 void Location::setHost(LocalDOMWindow* currentWindow,
                        LocalDOMWindow* enteredWindow,
                        const String& host,
                        ExceptionState& exceptionState) {
-  if (!m_frame)
-    return;
-  KURL url = toLocalFrame(m_frame)->document()->url();
+  KURL url = document()->url();
   url.setHostAndPort(host);
   setLocation(url.getString(), currentWindow, enteredWindow, &exceptionState);
 }
 
 void Location::setHostname(LocalDOMWindow* currentWindow,
                            LocalDOMWindow* enteredWindow,
                            const String& hostname,
                            ExceptionState& exceptionState) {
-  if (!m_frame)
-    return;
-  KURL url = toLocalFrame(m_frame)->document()->url();
+  KURL url = document()->url();
   url.setHost(hostname);
   setLocation(url.getString(), currentWindow, enteredWindow, &exceptionState);
 }
 
 void Location::setPort(LocalDOMWindow* currentWindow,
                        LocalDOMWindow* enteredWindow,
                        const String& portString,
                        ExceptionState& exceptionState) {
-  if (!m_frame)
-    return;
-  KURL url = toLocalFrame(m_frame)->document()->url();
+  KURL url = document()->url();
   url.setPort(portString);
   setLocation(url.getString(), currentWindow, enteredWindow, &exceptionState);
 }
 
 void Location::setPathname(LocalDOMWindow* currentWindow,
                            LocalDOMWindow* enteredWindow,
                            const String& pathname,
                            ExceptionState& exceptionState) {
-  if (!m_frame)
-    return;
-  KURL url = toLocalFrame(m_frame)->document()->url();
+  KURL url = document()->url();
   url.setPath(pathname);
   setLocation(url.getString(), currentWindow, enteredWindow, &exceptionState);
 }
 
 void Location::setSearch(LocalDOMWindow* currentWindow,
                          LocalDOMWindow* enteredWindow,
                          const String& search,
                          ExceptionState& exceptionState) {
-  if (!m_frame)
-    return;
-  KURL url = toLocalFrame(m_frame)->document()->url();
+  KURL url = document()->url();
   url.setQuery(search);
   setLocation(url.getString(), currentWindow, enteredWindow, &exceptionState);
 }
 
 void Location::setHash(LocalDOMWindow* currentWindow,
                        LocalDOMWindow* enteredWindow,
                        const String& hash,
                        ExceptionState& exceptionState) {
   TRACE_EVENT0("blink", "Location::setHash");
-  if (!m_frame)
-    return;
-  KURL url = toLocalFrame(m_frame)->document()->url();
+  KURL url = document()->url();
   String oldFragmentIdentifier = url.fragmentIdentifier();
   String newFragmentIdentifier = hash;
   if (hash[0] == '#')
     newFragmentIdentifier = hash.substring(1);
   url.setFragmentIdentifier(newFragmentIdentifier);
   // Note that by parsing the URL and *then* comparing fragments, we are
   // comparing fragments post-canonicalization, and so this handles the
   // cases where fragment identifiers are ignored or invalid.
   if (equalIgnoringNullity(oldFragmentIdentifier, url.fragmentIdentifier()))
     return;
   setLocation(url.getString(), currentWindow, enteredWindow, &exceptionState);
 }
 
 void Location::assign(LocalDOMWindow* currentWindow,
                       LocalDOMWindow* enteredWindow,
                       const String& url,
                       ExceptionState& exceptionState) {
   // TODO(yukishiino): Remove this check once we remove [CrossOrigin] from
   // the |assign| DOM operation's definition in Location.idl.  See the comment
   // in Location.idl for details.
   if (!BindingSecurity::shouldAllowAccessTo(currentWindow, this,
                                             exceptionState)) {
     return;
   }
 
-  if (!m_frame)
-    return;
   setLocation(url, currentWindow, enteredWindow, &exceptionState);
 }
 
 void Location::replace(LocalDOMWindow* currentWindow,
                        LocalDOMWindow* enteredWindow,
                        const String& url,
                        ExceptionState& exceptionState) {
-  if (!m_frame)
-    return;
   setLocation(url, currentWindow, enteredWindow, &exceptionState,
               SetLocationPolicy::ReplaceThisFrame);
 }
 
 void Location::reload(LocalDOMWindow* currentWindow) {
-  if (!m_frame)
+  if (!isAttached())
     return;
-  if (toLocalFrame(m_frame)->document()->url().protocolIsJavaScript())
+  if (document()->url().protocolIsJavaScript())
     return;
   FrameLoadType reloadType =
       RuntimeEnabledFeatures::fasterLocationReloadEnabled()
           ? FrameLoadTypeReloadMainResource
           : FrameLoadTypeReload;
-  m_frame->reload(reloadType, ClientRedirectPolicy::ClientRedirect);
+  m_domWindow->frame()->reload(reloadType,
+                               ClientRedirectPolicy::ClientRedirect);
 }
 
 void Location::setLocation(const String& url,
                            LocalDOMWindow* currentWindow,
                            LocalDOMWindow* enteredWindow,
                            ExceptionState* exceptionState,
                            SetLocationPolicy setLocationPolicy) {
-  DCHECK(m_frame);
-  if (!m_frame || !m_frame->host())
+  if (!isAttached())
     return;
 
   if (!currentWindow->frame())
     return;
 
-  if (!currentWindow->frame()->canNavigate(*m_frame)) {
+  if (!currentWindow->frame()->canNavigate(*m_domWindow->frame())) {
     if (exceptionState) {
       exceptionState->throwSecurityError(
           "The current window does not have permission to navigate the target "
           "frame to '" +
           url + "'.");
     }
     return;
   }
 
   Document* enteredDocument = enteredWindow->document();
   if (!enteredDocument)
     return;
 
   KURL completedURL = enteredDocument->completeURL(url);
   if (completedURL.isNull())
     return;
   if (exceptionState && !completedURL.isValid()) {
     exceptionState->throwDOMException(SyntaxError,
                                       "'" + url + "' is not a valid URL.");
     return;
   }
 
-  if (m_frame->domWindow()->isInsecureScriptAccess(*currentWindow,
-                                                   completedURL))
+  if (m_domWindow->isInsecureScriptAccess(*currentWindow, completedURL))
     return;
 
   V8DOMActivityLogger* activityLogger =
       V8DOMActivityLogger::currentActivityLoggerIfIsolatedWorld();
   if (activityLogger) {
     Vector<String> argv;
     argv.push_back("LocalDOMWindow");
     argv.push_back("url");
     argv.push_back(enteredDocument->url());
     argv.push_back(completedURL);
     activityLogger->logEvent("blinkSetAttribute", argv.size(), argv.data());
   }
-  m_frame->navigate(*currentWindow->document(), completedURL,
-                    setLocationPolicy == SetLocationPolicy::ReplaceThisFrame,
-                    UserGestureStatus::None);
+  m_domWindow->frame()->navigate(
+      *currentWindow->document(), completedURL,
+      setLocationPolicy == SetLocationPolicy::ReplaceThisFrame,
+      UserGestureStatus::None);
+}
+
+Document* Location::document() const {
+  return toLocalDOMWindow(m_domWindow)->document();
+}
+
+bool Location::isAttached() const {
+  return m_domWindow->frame() && m_domWindow->frame()->host();
 }
 
 }  // namespace blink