Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 270383002: Remove will-change: contents GPU rasterization hint (Closed)

Created:
6 years, 7 months ago by abarth-chromium
Modified:
6 years, 7 months ago
Reviewers:
ajuma, esprehn
CC:
blink-reviews, mstensho+blink_opera.com, jamesr, blink-reviews-rendering, krit, jbroman, zoltan1, rwlbuis, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, pdr., danakj, Stephen Chennney, rune+blink, nduca, ojan
Visibility:
Public.

Description

Remove will-change: contents GPU rasterization hint We've decided not to ship this configuration. The implementation also doesn't work because it incorrectly changes the paint order of elements with will-change: contents by make them into a NormalLayer. R=esprehn@chromium.org BUG=370604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173557

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -576 lines) Patch
D LayoutTests/compositing/will-change/gpu-rasterization-hint.html View 1 chunk +0 lines, -114 lines 0 comments Download
D LayoutTests/compositing/will-change/gpu-rasterization-hint-added.html View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/compositing/will-change/gpu-rasterization-hint-added-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/compositing/will-change/gpu-rasterization-hint-expected.txt View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/compositing/will-change/gpu-rasterization-hint-removed.html View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/compositing/will-change/gpu-rasterization-hint-removed-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/compositing/will-change/gpu-rasterization-hint-suppresses-compositing.html View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/compositing/will-change/gpu-rasterization-hint-suppresses-compositing-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 4 chunks +0 lines, -26 lines 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp View 6 chunks +0 lines, -12 lines 0 comments Download
M Source/core/rendering/compositing/CompositingTriggers.h View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 2 chunks +1 line, -21 lines 0 comments Download
M Source/platform/graphics/CompositingReasons.h View 4 chunks +4 lines, -8 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 11 (0 generated)
abarth-chromium
6 years, 7 months ago (2014-05-07 19:34:37 UTC) #1
ajuma
https://codereview.chromium.org/270383002/diff/1/public/web/WebSettings.h File public/web/WebSettings.h (right): https://codereview.chromium.org/270383002/diff/1/public/web/WebSettings.h#newcode69 public/web/WebSettings.h:69: virtual void setAcceleratedCompositingForGpuRasterizationHintEnabled(bool) { }; The chromium-side caller has ...
6 years, 7 months ago (2014-05-07 20:08:24 UTC) #2
abarth-chromium
On 2014/05/07 20:08:24, ajuma wrote: > https://codereview.chromium.org/270383002/diff/1/public/web/WebSettings.h > File public/web/WebSettings.h (right): > > https://codereview.chromium.org/270383002/diff/1/public/web/WebSettings.h#newcode69 > ...
6 years, 7 months ago (2014-05-07 20:28:00 UTC) #3
ajuma
On 2014/05/07 20:28:00, abarth wrote: > On 2014/05/07 20:08:24, ajuma wrote: > > https://codereview.chromium.org/270383002/diff/1/public/web/WebSettings.h > ...
6 years, 7 months ago (2014-05-07 20:28:46 UTC) #4
esprehn
lgtm
6 years, 7 months ago (2014-05-07 20:29:47 UTC) #5
abarth-chromium
Thanks!
6 years, 7 months ago (2014-05-07 20:38:33 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 7 months ago (2014-05-07 20:38:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/270383002/1
6 years, 7 months ago (2014-05-07 20:39:30 UTC) #8
commit-bot: I haz the power
Change committed as 173557
6 years, 7 months ago (2014-05-07 20:55:26 UTC) #9
kenneth.r.christiansen
Why don't you use the official specced (resolution: 2dppx) media query feature instead of the ...
6 years, 7 months ago (2014-05-12 11:28:32 UTC) #10
kenneth.r.christiansen
6 years, 7 months ago (2014-05-12 11:52:33 UTC) #11
Message was sent while issue was closed.
On 2014/05/12 11:28:32, kenneth.r.christiansen wrote:
> Why don't you use the official specced (resolution: 2dppx) media query feature
> instead of the unofficial -webkit-device-pixel-ratio?

I commented on the wrong CL... please ignore

Powered by Google App Engine
This is Rietveld 408576698