Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2703793003: vpython: Add filesystem operation / test packages. (Closed)

Created:
3 years, 10 months ago by dnj
Modified:
3 years, 10 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

vpython: Add filesystem operation / test packages. Adds the "filesystem" vpython package, which includes the filesystem operations used by the "vpython" tool. Also includes "filesystem/testfs", which are testing-oriented filesystem operations. Both of these will be heavily leveraged in future patch sets. BUG=chromium:691818 TEST=None Review-Url: https://codereview.chromium.org/2703793003 Committed: https://github.com/luci/luci-go/commit/091cb1591f7a0516f730228126c04e5574dc7db0

Patch Set 1 #

Total comments: 10

Patch Set 2 : add tests, comments #

Patch Set 3 : fix #

Patch Set 4 : up the filesystem timeout for macs #

Patch Set 5 : Touch takes a time now, test against the past for determinism without sleeping. #

Patch Set 6 : test now path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+574 lines, -0 lines) Patch
A vpython/filesystem/filesystem.go View 1 2 3 4 1 chunk +147 lines, -0 lines 0 comments Download
A vpython/filesystem/filesystem_test.go View 1 2 3 4 5 1 chunk +240 lines, -0 lines 0 comments Download
A vpython/filesystem/remove_all.go View 1 1 chunk +92 lines, -0 lines 0 comments Download
A vpython/filesystem/testfs/build.go View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A vpython/filesystem/testfs/tempdir.go View 1 1 chunk +40 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (12 generated)
dnj
PTAL! This is part of a larger "vpython" CL set for the tool. More information ...
3 years, 10 months ago (2017-02-17 23:17:13 UTC) #3
iannucci
lgtm https://codereview.chromium.org/2703793003/diff/1/vpython/filesystem/filesystem.go File vpython/filesystem/filesystem.go (right): https://codereview.chromium.org/2703793003/diff/1/vpython/filesystem/filesystem.go#newcode28 vpython/filesystem/filesystem.go:28: return errors.Annotate(err).Reason("unable to resolve absolute path"). did you ...
3 years, 10 months ago (2017-02-21 08:25:09 UTC) #4
iannucci
also... maybe add some tests?
3 years, 10 months ago (2017-02-21 08:25:38 UTC) #5
dnj
Added tests. Hopefully the timing ones aren't flaky, but they shouldn't be. https://codereview.chromium.org/2703793003/diff/1/vpython/filesystem/filesystem.go File vpython/filesystem/filesystem.go ...
3 years, 10 months ago (2017-02-21 18:07:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703793003/40001
3 years, 10 months ago (2017-02-22 06:51:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703793003/60001
3 years, 10 months ago (2017-02-22 06:58:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Mac Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/347d6e71b290c410)
3 years, 10 months ago (2017-02-22 07:05:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703793003/100001
3 years, 10 months ago (2017-02-22 07:16:09 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 07:21:29 UTC) #21
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://github.com/luci/luci-go/commit/091cb1591f7a0516f730228126c04e5574dc7db0

Powered by Google App Engine
This is Rietveld 408576698