Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 2703463006: vpython: Add README and environment protobuf. (Closed)

Created:
3 years, 10 months ago by dnj
Modified:
3 years, 10 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

vpython: Add README and environment protobuf. Add the vpython tool README and environment protobuf. The README details the tool and its layout and usage. BUG=chromium:691818 TEST=None Review-Url: https://codereview.chromium.org/2703463006 Committed: https://github.com/luci/luci-go/commit/49cc23e49067b4303d84e86a81e85d25bb27f3ee

Patch Set 1 #

Total comments: 34

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -0 lines) Patch
A vpython/README.md View 1 1 chunk +235 lines, -0 lines 0 comments Download
A vpython/api/env/gen.go View 1 chunk +14 lines, -0 lines 0 comments Download
A vpython/api/env/spec.proto View 1 1 chunk +46 lines, -0 lines 0 comments Download
A vpython/api/env/spec.pb.go View 1 1 chunk +134 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
dnj
PTAL! This is part of a larger "vpython" CL set for the tool. More information ...
3 years, 10 months ago (2017-02-17 23:17:05 UTC) #2
iannucci
lgtm w/ comments https://codereview.chromium.org/2703463006/diff/1/vpython/README.md File vpython/README.md (right): https://codereview.chromium.org/2703463006/diff/1/vpython/README.md#newcode11 vpython/README.md:11: * Change tool invocation from `python` ...
3 years, 10 months ago (2017-02-20 21:18:32 UTC) #3
dnj
https://codereview.chromium.org/2703463006/diff/1/vpython/README.md File vpython/README.md (right): https://codereview.chromium.org/2703463006/diff/1/vpython/README.md#newcode11 vpython/README.md:11: * Change tool invocation from `python` to `vpython`. On ...
3 years, 10 months ago (2017-02-22 06:39:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703463006/20001
3 years, 10 months ago (2017-02-22 06:39:30 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 06:47:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/49cc23e49067b4303d84e86a81e85d25bb27f3ee

Powered by Google App Engine
This is Rietveld 408576698