Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2703403002: Get rid of unused enum member DoNotUpdateAppearance from FrameSelection::SetSelectionOption (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of unused enum member DoNotUpdateAppearance from FrameSelection::SetSelectionOption This patch gets rid of unused enum member |DoNotUpdateAppearance| from |FrameSelection::SetSelectionOption| for improving code health. The usage of |DoNotUpdateAppearance| in |SpellCheckerTest| doesn't affect what the test verified. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2703403002 Cr-Commit-Position: refs/heads/master@{#451868} Committed: https://chromium.googlesource.com/chromium/src/+/fd4cb6042b4a053db98e1e57309b8132e3274f26

Patch Set 1 : 2017-02-22T00:32:44 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL Changes are in core/editing/
3 years, 10 months ago (2017-02-21 15:37:43 UTC) #5
Xiaocheng
lgtm
3 years, 10 months ago (2017-02-21 22:51:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703403002/1
3 years, 10 months ago (2017-02-21 23:21:54 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 01:21:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd4cb6042b4a053db98e1e57309b...

Powered by Google App Engine
This is Rietveld 408576698