third_party/WebKit/Source/core/editing/FrameSelection.cpp - Issue 2703403002: Get rid of unused enum member DoNotUpdateAppearance from FrameSelection::SetSelectionOption

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2703403002: Get rid of unused enum member DoNotUpdateAppearance from FrameSelection::SetSelectionOption (Closed)

Patch Set: 2017-02-22T00:32:44 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

index 7a0fa9a8dbdd5f6af3258dc8d58393e55bcee9a1..32f757091bc7672b4cd4d36b70da3af669fd239d 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

@@ -235,10 +235,8 @@ void FrameSelection::setSelection(const SelectionInDOMTree& passedSelection,

}

- if (!(options & DoNotUpdateAppearance)) {

- m_frameCaret->stopCaretBlinkTimer();

- updateAppearance();

- }

+ m_frameCaret->stopCaretBlinkTimer();

+ updateAppearance();

// Always clear the x position used for vertical arrow navigation.

// It will be restored by the vertical arrow navigation code if necessary.