Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2703403002: Get rid of unused enum member DoNotUpdateAppearance from FrameSelection::SetSelectionOption (Closed)
Patch Set: 2017-02-22T00:32:44 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 // |setFocusedNodeIfNeeded()| dispatches sync events "FocusOut" and 228 // |setFocusedNodeIfNeeded()| dispatches sync events "FocusOut" and
229 // "FocusIn", |m_frame| may associate to another document. 229 // "FocusIn", |m_frame| may associate to another document.
230 if (!isAvailable() || document() != currentDocument) { 230 if (!isAvailable() || document() != currentDocument) {
231 // Once we get test case to reach here, we should change this 231 // Once we get test case to reach here, we should change this
232 // if-statement to |DCHECK()|. 232 // if-statement to |DCHECK()|.
233 NOTREACHED(); 233 NOTREACHED();
234 return; 234 return;
235 } 235 }
236 } 236 }
237 237
238 if (!(options & DoNotUpdateAppearance)) { 238 m_frameCaret->stopCaretBlinkTimer();
239 m_frameCaret->stopCaretBlinkTimer(); 239 updateAppearance();
240 updateAppearance();
241 }
242 240
243 // Always clear the x position used for vertical arrow navigation. 241 // Always clear the x position used for vertical arrow navigation.
244 // It will be restored by the vertical arrow navigation code if necessary. 242 // It will be restored by the vertical arrow navigation code if necessary.
245 m_xPosForVerticalArrowNavigation = NoXPosForVerticalArrowNavigation(); 243 m_xPosForVerticalArrowNavigation = NoXPosForVerticalArrowNavigation();
246 // TODO(yosin): Can we move this to at end of this function? 244 // TODO(yosin): Can we move this to at end of this function?
247 // This may dispatch a synchronous focus-related events. 245 // This may dispatch a synchronous focus-related events.
248 selectFrameElementInParentIfFullySelected(); 246 selectFrameElementInParentIfFullySelected();
249 if (!isAvailable() || document() != currentDocument) { 247 if (!isAvailable() || document() != currentDocument) {
250 // editing/selection/selectallchildren-crash.html and 248 // editing/selection/selectallchildren-crash.html and
251 // editing/selection/longpress-selection-in-iframe-removed-crash.html 249 // editing/selection/longpress-selection-in-iframe-removed-crash.html
(...skipping 927 matching lines...) Expand 10 before | Expand all | Expand 10 after
1179 } 1177 }
1180 1178
1181 void showTree(const blink::FrameSelection* sel) { 1179 void showTree(const blink::FrameSelection* sel) {
1182 if (sel) 1180 if (sel)
1183 sel->showTreeForThis(); 1181 sel->showTreeForThis();
1184 else 1182 else
1185 LOG(INFO) << "Cannot showTree for <null> FrameSelection."; 1183 LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
1186 } 1184 }
1187 1185
1188 #endif 1186 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698