Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2703143002: [DevTools] Prepare to move Popover to shadow DOM. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Prepare to move Popover to shadow DOM. This patch encapsulates styles of ObjectPopoverHelper, image preview, network timing table and UISourceCodeFrame's message popover. BUG=none Review-Url: https://codereview.chromium.org/2703143002 Cr-Commit-Position: refs/heads/master@{#452308} Committed: https://chromium.googlesource.com/chromium/src/+/51dd8015de2619e1ef86f01f215ffe2dee297a6e

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -262 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html View 1 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/components/imagePreview.css View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/module.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/networkPanel.css View 1 chunk +2 lines, -138 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/network/networkTimingTable.css View 1 chunk +139 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/module.json View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/object_ui/objectPopover.css View 1 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js View 2 chunks +4 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/source_frame/messagesPopover.css View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/popover.css View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 36 (23 generated)
dgozman
Could you please take a look?
3 years, 10 months ago (2017-02-20 06:29:32 UTC) #4
alph
lgtm https://codereview.chromium.org/2703143002/diff/1/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html File third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html (right): https://codereview.chromium.org/2703143002/diff/1/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html#newcode40 third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html:40: value = Array.prototype.slice.call(value.children, 1).map(element => element.textContent).join(''); nit: Array.from(value.children, ...
3 years, 10 months ago (2017-02-21 21:21:33 UTC) #7
dgozman
Thank you for review! https://codereview.chromium.org/2703143002/diff/1/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html File third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html (right): https://codereview.chromium.org/2703143002/diff/1/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html#newcode40 third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html:40: value = Array.prototype.slice.call(value.children, 1).map(element => ...
3 years, 10 months ago (2017-02-21 21:34:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703143002/1
3 years, 10 months ago (2017-02-21 21:36:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-21 23:42:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703143002/1
3 years, 10 months ago (2017-02-22 00:06:41 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-22 02:09:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703143002/1
3 years, 10 months ago (2017-02-22 02:10:52 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-22 04:42:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703143002/1
3 years, 10 months ago (2017-02-22 15:27:58 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/370113) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 10 months ago (2017-02-22 15:31:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703143002/40001
3 years, 10 months ago (2017-02-23 00:20:37 UTC) #33
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 00:35:46 UTC) #36
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/51dd8015de2619e1ef86f01f215f...

Powered by Google App Engine
This is Rietveld 408576698