Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

Issue 2703143002: [DevTools] Prepare to move Popover to shadow DOM. (Closed)
Patch Set: fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
diff --git a/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
index 29773797b0d28cfdf828b8c39c13846066828ee0..7617975838622678f5374f8c1b2f32f40c1e689d 100644
--- a/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
+++ b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
@@ -128,6 +128,7 @@ ObjectUI.ObjectPopoverHelper = class extends UI.PopoverHelper {
if (result.type !== 'object') {
popoverContentElement = createElement('span');
UI.appendStyle(popoverContentElement, 'object_ui/objectValue.css');
+ UI.appendStyle(popoverContentElement, 'object_ui/objectPopover.css');
var valueElement = popoverContentElement.createChild('span', 'monospace object-value-' + result.type);
valueElement.style.whiteSpace = 'pre';
@@ -155,10 +156,11 @@ ObjectUI.ObjectPopoverHelper = class extends UI.PopoverHelper {
popoverContentElement = customPreviewComponent.element;
} else {
popoverContentElement = createElement('div');
+ UI.appendStyle(popoverContentElement, 'object_ui/objectPopover.css');
this._titleElement = popoverContentElement.createChild('div', 'monospace');
- this._titleElement.createChild('span', 'source-frame-popover-title').textContent = description;
+ this._titleElement.createChild('span', 'object-popover-title').textContent = description;
var section = new ObjectUI.ObjectPropertiesSection(result, '', this._lazyLinkifier());
- section.element.classList.add('source-frame-popover-tree');
+ section.element.classList.add('object-popover-tree');
section.titleLessMode();
popoverContentElement.appendChild(section.element);
}

Powered by Google App Engine
This is Rietveld 408576698