third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js - Issue 2703143002: [DevTools] Prepare to move Popover to shadow DOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

Issue 2703143002: [DevTools] Prepare to move Popover to shadow DOM. (Closed)

Patch Set: fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css ('k') | third_party/WebKit/Source/devtools/front_end/network/module.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

index f7e137f728d8b569cb626fbb5f2e91b476d200a5..fd29015ba3c65e16bf3e016ae67aee8b724fe8bb 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

@@ -180,6 +180,7 @@ Network.RequestTimingView = class extends UI.VBox {

static createTimingTable(request, calculator) {

var tableElement = createElementWithClass('table', 'network-timing-table');

+ UI.appendStyle(tableElement, 'network/networkTimingTable.css');

var colgroup = tableElement.createChild('colgroup');

colgroup.createChild('col', 'labels');

colgroup.createChild('col', 'bars');

@@ -212,10 +213,10 @@ Network.RequestTimingView = class extends UI.VBox {

if (rangeName === Network.RequestTimeRangeNames.Push) {

createHeader(Common.UIString('Server Push'));

} else if (rangeName === Network.RequestTimeRangeNames.Queueing) {

- queueingHeader = tableElement.createChild('tr', 'network-timing-table-header');

- queueingHeader.createChild('td').createTextChild(Common.UIString('Resource Scheduling'));

- queueingHeader.createChild('td').createTextChild('');

- queueingHeader.createChild('td').createTextChild(Common.UIString('TIME'));

+ queueingHeader = tableElement.createChild('tr', 'network-timing-table-header');

+ queueingHeader.createChild('td').createTextChild(Common.UIString('Resource Scheduling'));

+ queueingHeader.createChild('td').createTextChild('');

+ queueingHeader.createChild('td').createTextChild(Common.UIString('TIME'));

} else if (Network.RequestTimingView.ConnectionSetupRangeNames.has(rangeName)) {

if (!connectionHeader)

connectionHeader = createHeader(Common.UIString('Connection Start'));

@@ -339,6 +340,7 @@ Network.RequestTimingView = class extends UI.VBox {

this._tableElement.remove();

this._tableElement = Network.RequestTimingView.createTimingTable(this._request, this._calculator);

+ this._tableElement.classList.add('resource-timing-table');

this.element.appendChild(this._tableElement);

}

};