Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2701603004: Convert remaining PostUploadHooks to use EnsureCQIncludeTrybotsAreAdded. (Closed)

Created:
3 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, arv+watch_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert remaining PostUploadHooks to use EnsureCQIncludeTrybotsAreAdded. BUG=665150, 659139, 688765 TBR=dbeam@chromium.org,clamy@chromium.org,rockot@chromium.org,mcasas@chromium.org,dpranke@chromium.org,pdr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2701603004 Cr-Commit-Position: refs/heads/master@{#451158} Committed: https://chromium.googlesource.com/chromium/src/+/2a7e01bdad5216e739c2a18d1f0ff907641f6609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -79 lines) Patch
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +6 lines, -21 lines 0 comments Download
M content/browser/frame_host/PRESUBMIT.py View 1 chunk +6 lines, -18 lines 0 comments Download
M services/shape_detection/PRESUBMIT.py View 1 chunk +7 lines, -19 lines 0 comments Download
M third_party/WebKit/PRESUBMIT.py View 1 chunk +5 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Ken Russell (switch to Gerrit)
All: FYI. CQ'ing TBR'd. These presubmit changes have been well tested in an earlier CL ...
3 years, 10 months ago (2017-02-16 22:44:53 UTC) #6
mcasas
On 2017/02/16 22:44:53, Ken Russell wrote: > All: FYI. CQ'ing TBR'd. > > These presubmit ...
3 years, 10 months ago (2017-02-16 22:45:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701603004/1
3 years, 10 months ago (2017-02-16 22:46:27 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 00:38:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a7e01bdad5216e739c2a18d1f0f...

Powered by Google App Engine
This is Rietveld 408576698