Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: content/browser/frame_host/PRESUBMIT.py

Issue 2701603004: Convert remaining PostUploadHooks to use EnsureCQIncludeTrybotsAreAdded. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/PRESUBMIT.py ('k') | services/shape_detection/PRESUBMIT.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/PRESUBMIT.py
diff --git a/content/browser/frame_host/PRESUBMIT.py b/content/browser/frame_host/PRESUBMIT.py
index a6d6fbf4fc06194d623aaa82f516c306f71b352d..fd53c7ea47df11438433a89f3a71c00560ba0e3e 100644
--- a/content/browser/frame_host/PRESUBMIT.py
+++ b/content/browser/frame_host/PRESUBMIT.py
@@ -33,21 +33,9 @@ def PostUploadHook(cl, change, output_api):
This hook adds extra try bots to the CL description in order to run site
isolation tests in addition to CQ try bots.
"""
- rietveld_obj = cl.RpcServer()
- issue = cl.issue
- description = rietveld_obj.get_description(issue)
- if re.search(r'^CQ_INCLUDE_TRYBOTS=.*', description, re.M | re.I):
- return []
-
- masters = _GetTryMasters(None, change)
- results = []
- new_description = description
- new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(
- '%s:%s' % (master, ','.join(bots))
- for master, bots in masters.iteritems())
- results.append(output_api.PresubmitNotifyResult(
- 'Automatically added site isolation trybots to run tests on CQ.'))
-
- rietveld_obj.update_description(issue, new_description)
-
- return results
+ return output_api.EnsureCQIncludeTrybotsAreAdded(
+ cl,
+ [
+ 'master.tryserver.chromium.linux:linux_site_isolation'
+ ],
+ 'Automatically added site isolation trybots to run tests on CQ.')
« no previous file with comments | « chrome/browser/resources/PRESUBMIT.py ('k') | services/shape_detection/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698