Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: third_party/WebKit/PRESUBMIT.py

Issue 2701603004: Convert remaining PostUploadHooks to use EnsureCQIncludeTrybotsAreAdded. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shape_detection/PRESUBMIT.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/PRESUBMIT.py
diff --git a/third_party/WebKit/PRESUBMIT.py b/third_party/WebKit/PRESUBMIT.py
index ce54af2229b24c587b03898791d68870ef935ee7..3c4d66895e624ff3f255d38e69f9d96d3151d50d 100644
--- a/third_party/WebKit/PRESUBMIT.py
+++ b/third_party/WebKit/PRESUBMIT.py
@@ -362,25 +362,9 @@ def PostUploadHook(cl, change, output_api): # pylint: disable=C0103
"""
if not _ArePaintOrCompositingDirectoriesModified(change):
return []
-
- rietveld_obj = cl.RpcServer()
- issue = cl.issue
- description = rietveld_obj.get_description(issue)
- if re.search(r'^CQ_INCLUDE_TRYBOTS=.*', description, re.M | re.I):
- return []
-
- bots = [
- 'master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2',
- ]
-
- results = []
- new_description = description
- new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots)
- results.append(output_api.PresubmitNotifyResult(
+ return output_api.EnsureCQIncludeTrybotsAreAdded(
+ cl,
+ ['master.tryserver.chromium.linux:'
+ 'linux_layout_tests_slimming_paint_v2'],
'Automatically added slimming-paint-v2 tests to run on CQ due to '
- 'changes in paint or compositing directories.'))
-
- if new_description != description:
- rietveld_obj.update_description(issue, new_description)
-
- return results
+ 'changes in paint or compositing directories.')
« no previous file with comments | « services/shape_detection/PRESUBMIT.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698