Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(421)

Issue 2701573002: Remove //net from GN exec_script whitelist. (Closed)

Created:
9 months, 4 weeks ago by brettw
Modified:
9 months, 4 weeks ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove //net from GN exec_script whitelist. This used to use gypi_to_gn to read sources. Since that has been removed, this whitelist entry is no longer needed. Clarify the comment about gypi_to_gn usage: it's no longer the main reason for a whitelist entry. Review-Url: https://codereview.chromium.org/2701573002 Cr-Commit-Position: refs/heads/master@{#450842} Committed: https://chromium.googlesource.com/chromium/src/+/5bbea159fd30c4f7f1af838e12bf5dccb39e5dae

Patch Set 1 #

Messages

Total messages: 14 (8 generated)
brettw
9 months, 4 weeks ago (2017-02-15 21:13:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701573002/1
9 months, 4 weeks ago (2017-02-15 21:15:34 UTC) #5
Dirk Pranke
lgtm
9 months, 4 weeks ago (2017-02-15 21:21:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/383471)
9 months, 4 weeks ago (2017-02-15 22:29:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701573002/1
9 months, 4 weeks ago (2017-02-15 22:45:52 UTC) #11
commit-bot: I haz the power
9 months, 4 weeks ago (2017-02-16 00:44:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5bbea159fd30c4f7f1af838e12bf...

Powered by Google App Engine
This is Rietveld 0eb02b776