Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: .gn

Issue 2701573002: Remove //net from GN exec_script whitelist. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This file is used by the GN meta build system to find the root of the source 1 # This file is used by the GN meta build system to find the root of the source
2 # tree and to set startup options. For documentation on the values set in this 2 # tree and to set startup options. For documentation on the values set in this
3 # file, run "gn help dotfile" at the command line. 3 # file, run "gn help dotfile" at the command line.
4 4
5 import("//build/dotfile_settings.gni") 5 import("//build/dotfile_settings.gni")
6 6
7 # The location of the build configuration file. 7 # The location of the build configuration file.
8 buildconfig = "//build/config/BUILDCONFIG.gn" 8 buildconfig = "//build/config/BUILDCONFIG.gn"
9 9
10 # The secondary source root is a parallel directory tree where 10 # The secondary source root is a parallel directory tree where
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 "//v8/*", 188 "//v8/*",
189 "//win8/*", 189 "//win8/*",
190 ] 190 ]
191 191
192 # These are the list of GN files that run exec_script. This whitelist exists 192 # These are the list of GN files that run exec_script. This whitelist exists
193 # to force additional review for new uses of exec_script, which is strongly 193 # to force additional review for new uses of exec_script, which is strongly
194 # discouraged. 194 # discouraged.
195 # 195 #
196 # GYPI_TO_GN 196 # GYPI_TO_GN
197 # 197 #
198 # Most of these entries are for gypi_to_gn calls. We should not be adding new 198 # Some of these entries are for legacy gypi_to_gn calls. We should not be
199 # calls to this script in the build (see //build/gypi_to_gn.py for detailed 199 # adding new calls to this script in the build (see //build/gypi_to_gn.py for
200 # advice). The only time you should be editing this list for gypi_to_gn 200 # detailed advice). The only time you should be editing this list for
201 # purposes is when moving an existing call to a different place. 201 # gypi_to_gn purposes is when moving an existing call to a different place.
202 # 202 #
203 # PLEASE READ 203 # PLEASE READ
204 # 204 #
205 # You should almost never need to add new exec_script calls. exec_script is 205 # You should almost never need to add new exec_script calls. exec_script is
206 # slow, especially on Windows, and can cause confusing effects. Although 206 # slow, especially on Windows, and can cause confusing effects. Although
207 # individually each call isn't slow or necessarily very confusing, at the scale 207 # individually each call isn't slow or necessarily very confusing, at the scale
208 # of our repo things get out of hand quickly. By strongly pushing back on all 208 # of our repo things get out of hand quickly. By strongly pushing back on all
209 # additions, we keep the build fast and clean. If you think you need to add a 209 # additions, we keep the build fast and clean. If you think you need to add a
210 # new call, please consider: 210 # new call, please consider:
211 # 211 #
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 "//android_webview/BUILD.gn", 260 "//android_webview/BUILD.gn",
261 "//build_overrides/build.gni", 261 "//build_overrides/build.gni",
262 "//chromeos/BUILD.gn", 262 "//chromeos/BUILD.gn",
263 263
264 # TODO(dgn): Layer violation but breaks the build otherwise, see 264 # TODO(dgn): Layer violation but breaks the build otherwise, see
265 # https://crbug.com/474506. 265 # https://crbug.com/474506.
266 "//clank/java/BUILD.gn", 266 "//clank/java/BUILD.gn",
267 "//clank/native/BUILD.gn", 267 "//clank/native/BUILD.gn",
268 268
269 "//jingle/BUILD.gn", 269 "//jingle/BUILD.gn",
270 "//net/BUILD.gn",
271 "//remoting/host/installer/linux/BUILD.gn", 270 "//remoting/host/installer/linux/BUILD.gn",
272 "//remoting/remoting_version.gni", 271 "//remoting/remoting_version.gni",
273 "//remoting/host/installer/win/generate_clsids.gni", 272 "//remoting/host/installer/win/generate_clsids.gni",
274 273
275 # TODO(dpranke): Get these from the appropriate repos instead. 274 # TODO(dpranke): Get these from the appropriate repos instead.
276 "//third_party/angle/BUILD.gn", 275 "//third_party/angle/BUILD.gn",
277 "//third_party/angle/src/tests/BUILD.gn", 276 "//third_party/angle/src/tests/BUILD.gn",
278 "//third_party/angle/src/vulkan_support/BUILD.gn", 277 "//third_party/angle/src/vulkan_support/BUILD.gn",
279 "//third_party/catapult/tracing/BUILD.gn", 278 "//third_party/catapult/tracing/BUILD.gn",
280 "//third_party/google_input_tools/inputview.gni", 279 "//third_party/google_input_tools/inputview.gni",
281 280
282 # CLD2 should be removed soon, delete this when we do. 281 # CLD2 should be removed soon, delete this when we do.
283 "//third_party/cld_2/BUILD.gn", 282 "//third_party/cld_2/BUILD.gn",
284 "//tools/grit/grit_rule.gni", 283 "//tools/grit/grit_rule.gni",
285 284
286 # Not gypi-to-gn. 285 # Not gypi-to-gn.
287 "//google_apis/BUILD.gn", 286 "//google_apis/BUILD.gn",
288 "//printing/BUILD.gn", 287 "//printing/BUILD.gn",
289 ] 288 ]
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698