Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: .gn

Issue 2701573002: Remove //net from GN exec_script whitelist. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: .gn
diff --git a/.gn b/.gn
index c780bc3ce8c8dc576cb5ed7f11eb00fd0921e846..b0565e51a5d1fc494106700c35f11dd324abfed4 100644
--- a/.gn
+++ b/.gn
@@ -195,10 +195,10 @@ check_targets = [
#
# GYPI_TO_GN
#
-# Most of these entries are for gypi_to_gn calls. We should not be adding new
-# calls to this script in the build (see //build/gypi_to_gn.py for detailed
-# advice). The only time you should be editing this list for gypi_to_gn
-# purposes is when moving an existing call to a different place.
+# Some of these entries are for legacy gypi_to_gn calls. We should not be
+# adding new calls to this script in the build (see //build/gypi_to_gn.py for
+# detailed advice). The only time you should be editing this list for
+# gypi_to_gn purposes is when moving an existing call to a different place.
#
# PLEASE READ
#
@@ -267,7 +267,6 @@ exec_script_whitelist =
"//clank/native/BUILD.gn",
"//jingle/BUILD.gn",
- "//net/BUILD.gn",
"//remoting/host/installer/linux/BUILD.gn",
"//remoting/remoting_version.gni",
"//remoting/host/installer/win/generate_clsids.gni",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698