Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2700013002: Reland of [Mac] Version the //chrome:chrome_framework bundle. (Closed)

Created:
3 years, 10 months ago by Robert Sesek
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Mac] Version the //chrome:chrome_framework bundle. (patchset #1 id:1 of https://codereview.chromium.org/2669213003/ ) Reason for revert: Test build on 3012 passed. Original issue's description: > Revert of [Mac] Version the //chrome:chrome_framework bundle. (patchset #1 id:1 of https://codereview.chromium.org/2484283003/ ) > > Reason for revert: > Failed to sign in the official test build on 2998 (see https://crbug.com/688076). > > Original issue's description: > > [Mac] Version the //chrome:chrome_framework bundle. > > > > BUG=604809, 662466 > > TBR=dpranke@chromium.org > > > > Review-Url: https://codereview.chromium.org/2484283003 > > Cr-Commit-Position: refs/heads/master@{#447763} > > Committed: https://chromium.googlesource.com/chromium/src/+/5a1ebea8a247366ac822858e141983037a1f0059 > > TBR=miguelg@google.com,miguelg@chromium.org,dpranke@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=604809, 662466 > > Review-Url: https://codereview.chromium.org/2669213003 > Cr-Commit-Position: refs/heads/master@{#447816} > Committed: https://chromium.googlesource.com/chromium/src/+/d46123678f9f8e22c6210134bdbcfdb3e49b3bf2 TBR=miguelg@google.com,miguelg@chromium.org,dpranke@chromium.org NOTRY=true BUG=604809, 662466 Review-Url: https://codereview.chromium.org/2700013002 Cr-Commit-Position: refs/heads/master@{#451175} Committed: https://chromium.googlesource.com/chromium/src/+/247dfa7270288b09ff4ff433e616408102b51755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Robert Sesek
Created Reland of [Mac] Version the //chrome:chrome_framework bundle.
3 years, 10 months ago (2017-02-17 00:45:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700013002/1
3 years, 10 months ago (2017-02-17 00:46:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700013002/1
3 years, 10 months ago (2017-02-17 01:30:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/247dfa7270288b09ff4ff433e616408102b51755
3 years, 10 months ago (2017-02-17 02:08:34 UTC) #10
Nico
3 years, 10 months ago (2017-02-17 21:01:51 UTC) #12
Message was sent while issue was closed.
this probably caused
https://bugs.chromium.org/p/chromium/issues/detail?id=693721

Powered by Google App Engine
This is Rietveld 408576698