Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2484283003:
[Mac] Version the //chrome:chrome_framework bundle. (Closed)
|
Created:
4 years, 1 month ago by Robert Sesek Modified:
3 years, 10 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Version the //chrome:chrome_framework bundle.
BUG=604809, 662466
TBR=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2484283003
Cr-Commit-Position: refs/heads/master@{#447763}
Committed: https://chromium.googlesource.com/chromium/src/+/5a1ebea8a247366ac822858e141983037a1f0059
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== [Mac] Version the //chrome:chrome_framework bundle. BUG=604809 ========== to ========== [Mac] Version the //chrome:chrome_framework bundle. BUG=604809,662466 ==========
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rsesek@chromium.org changed reviewers: + miguelg@google.com
miguelg@chromium.org changed reviewers: + miguelg@chromium.org
lgtm
Description was changed from ========== [Mac] Version the //chrome:chrome_framework bundle. BUG=604809,662466 ========== to ========== [Mac] Version the //chrome:chrome_framework bundle. BUG=604809,662466 TBR=dpranke@chromium.org ==========
rsesek@chromium.org changed reviewers: + dpranke@chromium.org
TBR'ing dpranke@ for a one-line change
The CQ bit was checked by rsesek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486044105874460, "parent_rev":
"9ffbf3695efec80d623f334a50e1fa156cd2d62f", "commit_rev":
"5a1ebea8a247366ac822858e141983037a1f0059"}
Message was sent while issue was closed.
Description was changed from ========== [Mac] Version the //chrome:chrome_framework bundle. BUG=604809,662466 TBR=dpranke@chromium.org ========== to ========== [Mac] Version the //chrome:chrome_framework bundle. BUG=604809,662466 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2484283003 Cr-Commit-Position: refs/heads/master@{#447763} Committed: https://chromium.googlesource.com/chromium/src/+/5a1ebea8a247366ac822858e1419... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5a1ebea8a247366ac822858e1419...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2669213003/ by rsesek@chromium.org. The reason for reverting is: Failed to sign in the official test build on 2998 (see https://crbug.com/688076)..
Message was sent while issue was closed.
lgtm (and yes, I know it got reverted). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
