Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2669213003: Revert of [Mac] Version the //chrome:chrome_framework bundle. (Closed)

Created:
3 years, 10 months ago by Robert Sesek
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac] Version the //chrome:chrome_framework bundle. (patchset #1 id:1 of https://codereview.chromium.org/2484283003/ ) Reason for revert: Failed to sign in the official test build on 2998 (see https://crbug.com/688076). Original issue's description: > [Mac] Version the //chrome:chrome_framework bundle. > > BUG=604809, 662466 > TBR=dpranke@chromium.org > > Review-Url: https://codereview.chromium.org/2484283003 > Cr-Commit-Position: refs/heads/master@{#447763} > Committed: https://chromium.googlesource.com/chromium/src/+/5a1ebea8a247366ac822858e141983037a1f0059 TBR=miguelg@google.com,miguelg@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=604809, 662466 Review-Url: https://codereview.chromium.org/2669213003 Cr-Commit-Position: refs/heads/master@{#447816} Committed: https://chromium.googlesource.com/chromium/src/+/d46123678f9f8e22c6210134bdbcfdb3e49b3bf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Robert Sesek
Created Revert of [Mac] Version the //chrome:chrome_framework bundle.
3 years, 10 months ago (2017-02-02 19:25:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669213003/1
3 years, 10 months ago (2017-02-02 19:25:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d46123678f9f8e22c6210134bdbcfdb3e49b3bf2
3 years, 10 months ago (2017-02-02 19:30:38 UTC) #7
Dirk Pranke
lgtm
3 years, 10 months ago (2017-02-02 22:23:30 UTC) #8
Robert Sesek
3 years, 10 months ago (2017-02-17 00:45:15 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2700013002/ by rsesek@chromium.org.

The reason for reverting is: Test build on 3012 passed..

Powered by Google App Engine
This is Rietveld 408576698