LayoutTests/inspector/profiler/heap-snapshot-loader.html - Issue 27000005: Remove HeapProfiler.finishHeapSnapshot event from remote debugging protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-loader.html

Issue 27000005: Remove HeapProfiler.finishHeapSnapshot event from remote debugging protocol (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed heap profiler test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/inspector/profiler/heap-snapshot-loader.html

diff --git a/LayoutTests/inspector/profiler/heap-snapshot-loader.html b/LayoutTests/inspector/profiler/heap-snapshot-loader.html

index efd5b4ec1bc0a054aee7461668b067f0a249405f..336307a41ce5aaaeed1d45e6312dabcb12c18a7d 100644

--- a/LayoutTests/inspector/profiler/heap-snapshot-loader.html

+++ b/LayoutTests/inspector/profiler/heap-snapshot-loader.html

@@ -33,10 +33,10 @@ function test()

}

InspectorTest.override(HeapProfilerAgent, "getHeapSnapshot", getHeapSnapshotMock);

- function getHeapSnapshotMock(uid) {

+ function getHeapSnapshotMock(uid, callback) {

for (var i = 0, l = sourceStringified.length; i < l; i += partSize)

dispatcher.addHeapSnapshotChunk(uid, sourceStringified.slice(i, i + partSize));

- dispatcher.finishHeapSnapshot(uid);

+ callback();

}

dispatcher.addProfileHeader({