LayoutTests/inspector/profiler/heap-snapshot-test.js - Issue 27000005: Remove HeapProfiler.finishHeapSnapshot event from remote debugging protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-test.js

Issue 27000005: Remove HeapProfiler.finishHeapSnapshot event from remote debugging protocol (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed heap profiler test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/inspector/profiler/heap-snapshot-test.js

diff --git a/LayoutTests/inspector/profiler/heap-snapshot-test.js b/LayoutTests/inspector/profiler/heap-snapshot-test.js

index 6934be6ca2de02afd35f34f880c90fa3afd20c87..164bb201443b5495567b55f7d794c5135c27b5f7 100644

--- a/LayoutTests/inspector/profiler/heap-snapshot-test.js

+++ b/LayoutTests/inspector/profiler/heap-snapshot-test.js

@@ -694,13 +694,13 @@ InspectorTest.takeAndOpenSnapshot = function(generator, callback)

maxJSObjectId: snapshot.maxJSObjectId

});

delete snapshot.maxJSObjectId;

- function pushGeneratedSnapshot(uid)

+ function pushGeneratedSnapshot(uid, callback)

{

snapshot.snapshot.typeId = "HEAP";

snapshot.snapshot.title = profile.title;

snapshot.snapshot.uid = profile.uid;

profileType.addHeapSnapshotChunk(uid, JSON.stringify(snapshot));

- profileType.finishHeapSnapshot(uid);

+ callback();

}

InspectorTest.override(HeapProfilerAgent, "getHeapSnapshot", pushGeneratedSnapshot);

InspectorTest._takeAndOpenSnapshotCallback = callback;