LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html - Issue 27000005: Remove HeapProfiler.finishHeapSnapshot event from remote debugging protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

Issue 27000005: Remove HeapProfiler.finishHeapSnapshot event from remote debugging protocol (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed heap profiler test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector-protocol/heap-profiler/resources/heap-snapshot-common.js ('k') | LayoutTests/inspector/profiler/heap-snapshot-loader.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

diff --git a/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html b/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

index 842c67e95e68057f10c3a6e4939b27a947fe4e01..ea6c6e4b262a28b93629f50bae0c7fbd8d7eadb1 100644

--- a/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

+++ b/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

@@ -16,9 +16,9 @@ function test()

WebInspector.showPanel("profiles");

WebInspector.panels.profiles._createTemporaryProfile("HEAP");

var heapProfileType = WebInspector.panels.profiles.getProfileType("HEAP");

- InspectorTest.addSniffer(heapProfileType, "finishHeapSnapshot", finishHeapSnapshot);

+ heapProfileType.addEventListener(WebInspector.HeapSnapshotProfileType.SnapshotReceived, finishHeapSnapshot);

InspectorTest.addSniffer(heapProfileType, "_snapshotReceived", snapshotReceived);

- HeapProfilerAgent.takeHeapSnapshot(function() { });

+ heapProfileType._takeHeapSnapshot(function() {});

function finishHeapSnapshot(uid)

{