Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 27000005: Remove HeapProfiler.finishHeapSnapshot event from remote debugging protocol (Closed)

Created:
7 years, 2 months ago by yurys
Modified:
7 years, 2 months ago
Reviewers:
alph, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove HeapProfiler.finishHeapSnapshot event from remote debugging protocol This event is redundant as it is sent right before the response to HeapProfiler.getHeapSnapshot command. The command response should be used instead of the event. BUG=306475 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159652

Patch Set 1 #

Patch Set 2 : Fixed heap profiler test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -66 lines) Patch
M LayoutTests/inspector-protocol/heap-profiler/resources/heap-snapshot-common.js View 1 2 chunks +10 lines, -15 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-loader.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/CPUProfileView.js View 1 1 chunk +0 lines, -6 lines 0 comments Download
M Source/devtools/front_end/HeapSnapshotView.js View 1 5 chunks +11 lines, -32 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
There is a few usages of this event in the telemetry code which should be ...
7 years, 2 months ago (2013-10-11 11:30:58 UTC) #1
loislo
lgtm
7 years, 2 months ago (2013-10-11 11:45:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/27000005/1
7 years, 2 months ago (2013-10-15 07:35:43 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=8259
7 years, 2 months ago (2013-10-15 08:22:38 UTC) #4
yurys
7 years, 2 months ago (2013-10-15 09:00:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r159652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698