Remove ComputedStyleBase::setBitsDefault().

Remove ComputedStyleBase::setBitsDefault().

ComputedStyle::setBitDefaults() resets its members to their initial
value. Since part of ComputedStyle is generated in ComputedStyleBase,
this method also calls ComputedStyleBase::setBitDefaults(), which resets
the generated members as well.

However, ComputedStyle::setBitDefaults() is only called in the
ComputedStyle constructors, so the generated members are initialised
once in the ComputedStyleBase constructor (since its a base class), and
then re-initialised a second time by a setBitDefaults() call in the
constructor body.

This patch removes ComputedStyleBase::setBitDefaults() so that
generated members are only initialised once, not twice. It also renames
ComputedStyle::setBitDefaults() to initializeBitDefaults() so it's
clearer that it's meant to be used inside the constructor.

BUG=628043
Review-Url: https://codereview.chromium.org/2699843002
Cr-Commit-Position: refs/heads/master@{#451666}
Committed: https://chromium.googlesource.com/chromium/src/+/f6f56fb3cadf1933dbc1b9f3419f13399287bc5d

[shend, 2017-02-16 04:35:33]

Description was changed from

==========
Remove ComputedStyleBase::setBitsDefault().

ComputedStyle::setBitDefaults() resets its members to their initial
value. Since part of ComputedStyle is generated in ComputedStyleBase,
this method also calls ComputedStyleBase::setBitDefaults(), which resets
the generated members as well.

However, ComputedStyle::setBitDefaults() is only called in the
ComputedStyle constructors, so the generated members are initialised
once in the ComputedStyleBase constructor (since its a base class), and
then re-initialised a second time by a setBitDefaults() call in the
constructor body.

This patch removes ComputedStyleBase::setBitDefaults() and adds a
comment warning people to not use ComputedStyle::setBitDefaults()
outside of constructors since it won't reset the generated members.

BUG=628043
==========

to

==========
Remove ComputedStyleBase::setBitsDefault().

ComputedStyle::setBitDefaults() resets its members to their initial
value. Since part of ComputedStyle is generated in ComputedStyleBase,
this method also calls ComputedStyleBase::setBitDefaults(), which resets
the generated members as well.

However, ComputedStyle::setBitDefaults() is only called in the
ComputedStyle constructors, so the generated members are initialised
once in the ComputedStyleBase constructor (since its a base class), and
then re-initialised a second time by a setBitDefaults() call in the
constructor body.

This patch removes ComputedStyleBase::setBitDefaults() so that
generated members are only initialised once, not twice. It also adds a
comment warning people to not use ComputedStyle::setBitDefaults()
outside of constructors since it won't reset the generated members.

BUG=628043
==========

[shend, 2017-02-16 04:37:44]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-02-16 04:37:45]

Hi Naina, PTAL

[nainar, 2017-02-16 04:48:57]

lgtm

[shend, 2017-02-16 04:55:25]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-02-16 04:55:26]

Hi Eddy, PTAL :)

[shend, 2017-02-16 05:59:57]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 06:01:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 06:15:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 06:15:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shend, 2017-02-16 06:40:18]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 06:41:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 09:01:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 09:01:14]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2017-02-17 06:41:48]

lgtm

Perhaps it would be better to rename the function to "initializeBitDefaults",
which sounds more like it should not be called outside of initialization/the
constructor?

[shend, 2017-02-19 22:38:30]

On 2017/02/17 at 06:41:48, meade wrote:
> lgtm
> 
> Perhaps it would be better to rename the function to "initializeBitDefaults",
which sounds more like it should not be called outside of initialization/the
constructor?

Done. Also made the comment less shouty.

[shend, 2017-02-19 23:21:50]

Description was changed from

==========
Remove ComputedStyleBase::setBitsDefault().

ComputedStyle::setBitDefaults() resets its members to their initial
value. Since part of ComputedStyle is generated in ComputedStyleBase,
this method also calls ComputedStyleBase::setBitDefaults(), which resets
the generated members as well.

However, ComputedStyle::setBitDefaults() is only called in the
ComputedStyle constructors, so the generated members are initialised
once in the ComputedStyleBase constructor (since its a base class), and
then re-initialised a second time by a setBitDefaults() call in the
constructor body.

This patch removes ComputedStyleBase::setBitDefaults() so that
generated members are only initialised once, not twice. It also adds a
comment warning people to not use ComputedStyle::setBitDefaults()
outside of constructors since it won't reset the generated members.

BUG=628043
==========

to

==========
Remove ComputedStyleBase::setBitsDefault().

ComputedStyle::setBitDefaults() resets its members to their initial
value. Since part of ComputedStyle is generated in ComputedStyleBase,
this method also calls ComputedStyleBase::setBitDefaults(), which resets
the generated members as well.

However, ComputedStyle::setBitDefaults() is only called in the
ComputedStyle constructors, so the generated members are initialised
once in the ComputedStyleBase constructor (since its a base class), and
then re-initialised a second time by a setBitDefaults() call in the
constructor body.

This patch removes ComputedStyleBase::setBitDefaults() so that
generated members are only initialised once, not twice. It also renames
ComputedStyle::setBitDefaults() to initializeBitDefaults() so it's
clearer that it's meant to be used inside the constructor.

BUG=628043
==========

[shend, 2017-02-20 06:06:44]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 06:07:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 07:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 07:55:46]

Dry run: This issue passed the CQ dry run.

[shend, 2017-02-20 22:36:00]

The CQ bit was checked by shend@chromium.org

[shend, 2017-02-20 22:36:00]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2699843002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-02-20 22:36:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 22:40:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487630160273840,
"parent_rev": "c6e9b13174cd446b65b679bdfca1c8a8dc25ac1c", "commit_rev":
"f6f56fb3cadf1933dbc1b9f3419f13399287bc5d"}

[commit-bot: I haz the power, 2017-02-20 22:40:55]

Description was changed from

==========
Remove ComputedStyleBase::setBitsDefault().

ComputedStyle::setBitDefaults() resets its members to their initial
value. Since part of ComputedStyle is generated in ComputedStyleBase,
this method also calls ComputedStyleBase::setBitDefaults(), which resets
the generated members as well.

However, ComputedStyle::setBitDefaults() is only called in the
ComputedStyle constructors, so the generated members are initialised
once in the ComputedStyleBase constructor (since its a base class), and
then re-initialised a second time by a setBitDefaults() call in the
constructor body.

This patch removes ComputedStyleBase::setBitDefaults() so that
generated members are only initialised once, not twice. It also renames
ComputedStyle::setBitDefaults() to initializeBitDefaults() so it's
clearer that it's meant to be used inside the constructor.

BUG=628043
==========

to

==========
Remove ComputedStyleBase::setBitsDefault().

ComputedStyle::setBitDefaults() resets its members to their initial
value. Since part of ComputedStyle is generated in ComputedStyleBase,
this method also calls ComputedStyleBase::setBitDefaults(), which resets
the generated members as well.

However, ComputedStyle::setBitDefaults() is only called in the
ComputedStyle constructors, so the generated members are initialised
once in the ComputedStyleBase constructor (since its a base class), and
then re-initialised a second time by a setBitDefaults() call in the
constructor body.

This patch removes ComputedStyleBase::setBitDefaults() so that
generated members are only initialised once, not twice. It also renames
ComputedStyle::setBitDefaults() to initializeBitDefaults() so it's
clearer that it's meant to be used inside the constructor.

BUG=628043

Review-Url: https://codereview.chromium.org/2699843002
Cr-Commit-Position: refs/heads/master@{#451666}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6f56fb3cadf1933dbc1b9f3419f...
==========

[commit-bot: I haz the power, 2017-02-20 22:40:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f6f56fb3cadf1933dbc1b9f3419f...