Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2699843002: Remove ComputedStyleBase::setBitsDefault(). (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index bc38abc13cb784e065807157793231de423cbf34..08720ae4b90cfe764ad1910260a44adf9e7d3fff 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -124,7 +124,8 @@ ALWAYS_INLINE ComputedStyle::ComputedStyle()
m_rareInheritedData(initialStyle().m_rareInheritedData),
m_styleInheritedData(initialStyle().m_styleInheritedData),
m_svgStyle(initialStyle().m_svgStyle) {
- setBitDefaults(); // Would it be faster to copy this from the default style?
+ initializeBitDefaults(); // Would it be faster to copy this from the default
+ // style?
static_assert((sizeof(InheritedData) <= 8), "InheritedData should not grow");
static_assert((sizeof(NonInheritedData) <= 12),
"NonInheritedData should not grow");
@@ -132,7 +133,7 @@ ALWAYS_INLINE ComputedStyle::ComputedStyle()
ALWAYS_INLINE ComputedStyle::ComputedStyle(InitialStyleTag)
: ComputedStyleBase(), RefCounted<ComputedStyle>() {
- setBitDefaults();
+ initializeBitDefaults();
m_box.init();
m_visual.init();
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698