Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2699843002: Remove ComputedStyleBase::setBitsDefault(). (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index 37acb410f78a9b255ed89c0ef28e5593e70e7fc7..a297c5161541deb76dafa67718c5da50565ba825 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -290,9 +290,9 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
// !END SYNC!
- void setBitDefaults() {
- // Generated properties are updated in ComputedStyleBase
- ComputedStyleBase::setBitDefaults();
+ // Only call inside the constructor. Generated properties in the base class
+ // are not initialized in this method.
+ void initializeBitDefaults() {
m_inheritedData.m_hasSimpleUnderline = false;
m_inheritedData.m_cursorStyle = static_cast<unsigned>(initialCursor());
m_inheritedData.m_insideLink =

Powered by Google App Engine
This is Rietveld 408576698