Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 2699663003: Convert utility process extension ParseUpdate IPC to mojo

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 2 days ago by noel gordon
Modified:
2 days, 6 hours ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), catmullings, Devlin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert utility process extension ParseUpdate IPC to mojo Depends on http://crrev.com/2697463002 BUG=691410

Patch Set 1 #

Patch Set 2 : Mojo Traits: Add an out-of-line UpdateManifest::Results copy constructor. #

Patch Set 3 : Done. #

Patch Set 4 : Rename updater to parser. #

Patch Set 5 : Fix git apply issue. #

Patch Set 6 #

Patch Set 7 : Sync to ToT, see if git apply is happy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -198 lines) Patch
M chrome/browser/chrome_content_utility_manifest_overlay.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.h View 1 2 3 4 5 5 chunks +3 lines, -7 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 1 2 3 4 5 3 chunks +2 lines, -9 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 1 1 chunk +5 lines, -7 lines 0 comments Download
M extensions/browser/updater/safe_manifest_parser.h View 1 2 3 1 chunk +6 lines, -37 lines 0 comments Download
M extensions/browser/updater/safe_manifest_parser.cc View 1 2 3 4 5 6 1 chunk +28 lines, -55 lines 0 comments Download
M extensions/common/BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/common/OWNERS View 1 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/extension_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/common/extension_utility_messages.h View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
A extensions/common/manifest_parser.mojom View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A extensions/common/manifest_parser.typemap View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A extensions/common/manifest_parser_struct_traits.h View 1 2 3 1 chunk +81 lines, -0 lines 0 comments Download
A extensions/common/manifest_parser_struct_traits.cc View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download
A extensions/common/typemaps.gni View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/update_manifest.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/update_manifest.cc View 1 1 chunk +7 lines, -8 lines 0 comments Download
M extensions/shell/utility/shell_content_utility_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/shell/utility/shell_content_utility_client.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M extensions/test/data/extensions_test_content_utility_manifest_overlay.json View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M extensions/test/test_content_utility_client.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/test/test_content_utility_client.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/utility/unpacker.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/utility/utility_handler.h View 1 2 3 4 5 1 chunk +2 lines, -22 lines 0 comments Download
M extensions/utility/utility_handler.cc View 1 2 3 3 chunks +25 lines, -30 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +1 line, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 69 (68 generated)
noel gordon
1 week, 2 days ago (2017-02-16 03:51:40 UTC) #7
On 2017/02/16 01:53:40, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Mojo struct traits: UpdateManifest::Results has an inline copy constructor. 
Clang compilers do not like it, nor does Chromium style.

Fix: define the copy constructor in the .h, and provide an out-of-line impl in
the .cc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd