Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/utility/extensions/extensions_handler.h

Issue 2699663003: Convert utility process extension ParseUpdate IPC to mojo (Closed)
Patch Set: Extensions review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/chrome_content_utility_client.cc ('k') | chrome/utility/extensions/extensions_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/extensions/extensions_handler.h
diff --git a/chrome/utility/extensions/extensions_handler.h b/chrome/utility/extensions/extensions_handler.h
index bdeb3592f338bdafbe92e662cb0f9a2f46e6159e..9c3c6e06e0de9c718f1119bf0828d5ff8a3a3bb8 100644
--- a/chrome/utility/extensions/extensions_handler.h
+++ b/chrome/utility/extensions/extensions_handler.h
@@ -8,7 +8,6 @@
#include <stdint.h>
#include "base/base64.h"
-#include "base/compiler_specific.h"
#include "base/macros.h"
#include "build/build_config.h"
#include "chrome/common/media_galleries/picasa_types.h"
@@ -27,6 +26,8 @@ class InterfaceRegistry;
namespace extensions {
// Dispatches IPCs for Chrome extensions utility messages.
+// Note: these IPC are deprecated so there is no need to convert
+// them to mojo. https://crbug.com/680928
class ExtensionsHandler : public UtilityMessageHandler {
public:
ExtensionsHandler();
@@ -34,8 +35,6 @@ class ExtensionsHandler : public UtilityMessageHandler {
static void PreSandboxStartup();
- // TODO(noel): consider moving this API to the UtilityMessageHandler
- // interface.
static void ExposeInterfacesToBrowser(
service_manager::InterfaceRegistry* registry,
bool running_elevated);
@@ -61,8 +60,6 @@ class ExtensionsHandler : public UtilityMessageHandler {
const std::vector<picasa::FolderINIContents>& folders_inis);
#endif // defined(OS_WIN) || defined(OS_MACOSX)
- UtilityHandler utility_handler_;
-
DISALLOW_COPY_AND_ASSIGN(ExtensionsHandler);
};
« no previous file with comments | « chrome/utility/chrome_content_utility_client.cc ('k') | chrome/utility/extensions/extensions_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698