extensions/common/manifest_parser.typemap - Issue 2699663003: Convert utility process extension ParseUpdate IPC to mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/common/manifest_parser.typemap

Issue 2699663003: Convert utility process extension ParseUpdate IPC to mojo (Closed)

Patch Set: Another change landed in this area, sync up to ToT. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« extensions/browser/updater/safe_manifest_parser.cc ('K') | « extensions/common/manifest_parser.mojom ('k') | extensions/common/manifest_parser_struct_traits.h » ('j') | extensions/utility/utility_handler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 mojom = "//extensions/common/manifest_parser.mojom"

	6

	7 public_headers = [ "//extensions/common/update_manifest.h" ]

	8

	9 traits_headers = [ "//extensions/common/manifest_parser_struct_traits.h" ]

	10

	11 sources = [

	12 "//extensions/common/manifest_parser_struct_traits.cc",

	13 ]

	14

	15 type_mappings = [

	16 "extensions.mojom.UpdateManifestResults=::UpdateManifest::Results",
	Devlin 2017/03/21 23:51:16 I wonder if it would make sense to just use the mo I wonder if it would make sense to just use the mojo types instead of UpdateManifest::Results? It would save on conversion/copies, and they're just data structs... maybe add a TODO somewhere? (In UpdateManifest?) Noel Gordon 2017/03/22 01:34:50 You might recall the recent enum Manifest::locatio Show quoted text On 2017/03/21 23:51:16, Devlin wrote: > I wonder if it would make sense to just use the mojo types instead of > UpdateManifest::Results? You might recall the recent enum Manifest::location change we did. We did think about re-writing callers in terms of the mojo enum type (didn't mention it as option in review), but there were many call-sites in extensions that would'a needed updating to do that (too many for that particular patch set). But "just use the mojo types instead" is always good thing to consider, given ... Show quoted text > It would save on conversion/copies, and they're just > data structs... and, furthermore, saves you having to decide upon using [Native] traits, or else building mojo struct traits, etc, etc. So indeed, lots of benefits and, assuming callers / call-sites can be easily updated to use the mojo type(s), it's a good way to go ... Show quoted text > maybe add a TODO somewhere? (In UpdateManifest?) ... or consider: TODO done.
	17 "extensions.mojom.UpdateManifestResult=::UpdateManifest::Result",

	18 ]

OLD	NEW