Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2699253002: Removed CRWSessionEntry unittests. (Closed)

Created:
3 years, 10 months ago by kkhorimoto
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed CRWSessionEntry unittests. This CL also adds a debug description method to NavigationItemImpl and transfers CRWSessionEntry's description tests to NavigationItemImpl. BUG=454984 Review-Url: https://codereview.chromium.org/2699253002 Cr-Commit-Position: refs/heads/master@{#455576} Committed: https://chromium.googlesource.com/chromium/src/+/ba9b18a3417349ca08aba141f3971b61923a9e01

Patch Set 1 #

Total comments: 8

Patch Set 2 : rebase + eugene's comments #

Patch Set 3 : rebase #

Patch Set 4 : fix test #

Patch Set 5 : add ifndef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -112 lines) Patch
M ios/web/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/navigation/crw_session_entry.mm View 1 2 1 chunk +5 lines, -12 lines 0 comments Download
D ios/web/navigation/crw_session_entry_unittest.mm View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
M ios/web/navigation/navigation_item_impl.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M ios/web/navigation/navigation_item_impl.mm View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M ios/web/navigation/navigation_item_impl_unittest.mm View 1 2 3 4 3 chunks +27 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (15 generated)
kkhorimoto
3 years, 10 months ago (2017-02-17 23:45:20 UTC) #2
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2699253002/diff/1/ios/web/navigation/crw_session_entry_unittest.mm File ios/web/navigation/crw_session_entry_unittest.mm (left): https://codereview.chromium.org/2699253002/diff/1/ios/web/navigation/crw_session_entry_unittest.mm#oldcode83 ios/web/navigation/crw_session_entry_unittest.mm:83: TEST_F(CRWSessionEntryTest, EmptyVirtualUrl) { Could you please move VirtualURL tests ...
3 years, 10 months ago (2017-02-18 01:26:00 UTC) #3
kkhorimoto
https://codereview.chromium.org/2699253002/diff/1/ios/web/navigation/crw_session_entry_unittest.mm File ios/web/navigation/crw_session_entry_unittest.mm (left): https://codereview.chromium.org/2699253002/diff/1/ios/web/navigation/crw_session_entry_unittest.mm#oldcode83 ios/web/navigation/crw_session_entry_unittest.mm:83: TEST_F(CRWSessionEntryTest, EmptyVirtualUrl) { On 2017/02/18 01:25:59, Eugene But wrote: ...
3 years, 9 months ago (2017-03-02 01:55:56 UTC) #4
Eugene But (OOO till 7-30)
lgtm
3 years, 9 months ago (2017-03-02 02:03:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699253002/20001
3 years, 9 months ago (2017-03-07 05:20:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/165754) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-07 05:24:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699253002/40001
3 years, 9 months ago (2017-03-08 18:38:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/166925) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-08 18:49:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699253002/60001
3 years, 9 months ago (2017-03-08 19:16:12 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/166962)
3 years, 9 months ago (2017-03-08 19:30:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699253002/80001
3 years, 9 months ago (2017-03-08 21:31:00 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/336497)
3 years, 9 months ago (2017-03-08 22:28:24 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699253002/80001
3 years, 9 months ago (2017-03-08 22:29:31 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 23:03:54 UTC) #29
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ba9b18a3417349ca08aba141f397...

Powered by Google App Engine
This is Rietveld 408576698