Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: ios/web/navigation/crw_session_entry.mm

Issue 2699253002: Removed CRWSessionEntry unittests. (Closed)
Patch Set: add ifndef Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/BUILD.gn ('k') | ios/web/navigation/crw_session_entry_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/crw_session_entry.mm
diff --git a/ios/web/navigation/crw_session_entry.mm b/ios/web/navigation/crw_session_entry.mm
index bd6e24bb7bab3c6bcc81ad09cc0f6c4b49e8435e..59ef93503e267701552f30b734ff662950e4cd6a 100644
--- a/ios/web/navigation/crw_session_entry.mm
+++ b/ios/web/navigation/crw_session_entry.mm
@@ -50,18 +50,11 @@ - (instancetype)copyWithZone:(NSZone*)zone {
}
- (NSString*)description {
- return [NSString
- stringWithFormat:
- @"url:%@ originalurl:%@ title:%@ transition:%d displayState:%@ "
- @"userAgentType:%s",
- base::SysUTF8ToNSString(_navigationItem->GetURL().spec()),
- base::SysUTF8ToNSString(
- _navigationItem->GetOriginalRequestURL().spec()),
- base::SysUTF16ToNSString(_navigationItem->GetTitle()),
- _navigationItem->GetTransitionType(),
- _navigationItem->GetPageDisplayState().GetDescription(),
- web::GetUserAgentTypeDescription(_navigationItem->GetUserAgentType())
- .c_str()];
+#ifndef NDEBUG
+ return _navigationItem->GetDescription();
+#else
+ return [super description];
+#endif
}
- (web::NavigationItem*)navigationItem {
« no previous file with comments | « ios/web/BUILD.gn ('k') | ios/web/navigation/crw_session_entry_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698