Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: ios/web/navigation/navigation_item_impl_unittest.mm

Issue 2699253002: Removed CRWSessionEntry unittests. (Closed)
Patch Set: add ifndef Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/navigation_item_impl.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/navigation_item_impl_unittest.mm
diff --git a/ios/web/navigation/navigation_item_impl_unittest.mm b/ios/web/navigation/navigation_item_impl_unittest.mm
index b5e08ebe7975e604fb8ac643d9580b499c4ad720..a2866276551c7fe011866eff90ae5a20830c395f 100644
--- a/ios/web/navigation/navigation_item_impl_unittest.mm
+++ b/ios/web/navigation/navigation_item_impl_unittest.mm
@@ -8,7 +8,7 @@
#include "base/logging.h"
#import "base/mac/scoped_nsobject.h"
-#include "base/strings/sys_string_conversions.h"
+#include "base/strings/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
#import "testing/gtest_mac.h"
#include "testing/platform_test.h"
@@ -45,6 +45,18 @@ void SetUp() override {
EXPECT_TRUE(item_->GetURL().is_valid());
}
+#ifndef NDEBUG
+// Tests that the debug description is as expected.
+TEST_F(NavigationItemTest, Description) {
+ item_->SetTitle(base::UTF8ToUTF16("Title"));
+ EXPECT_NSEQ(@"url:http://init.test/ originalurl:http://init.test/ "
+ @"title:Title transition:2 displayState:{ scrollOffset:(nan, "
+ @"nan), zoomScaleRange:(nan, nan), zoomScale:nan } "
+ @"userAgentType:MOBILE",
+ item_->GetDescription());
+}
+#endif
+
// Tests that copied NavigationItemImpls create copies of data members that are
// objects.
TEST_F(NavigationItemTest, Copy) {
@@ -122,5 +134,19 @@ void SetUp() override {
EXPECT_EQ(original_url, copy.GetOriginalRequestURL());
}
+// Tests the behavior of GetVirtualURL().
+TEST_F(NavigationItemTest, VirtualURLTest) {
+ // Ensure that GetVirtualURL() returns GetURL() when not set to a custom
+ // value.
+ GURL original_url = item_->GetURL();
+ EXPECT_EQ(original_url, item_->GetVirtualURL());
+ // Set the virtual URL and check that the correct value is reported and that
+ // GetURL() still reports the original URL.
+ GURL new_virtual_url = GURL("http://new_url.test");
+ item_->SetVirtualURL(new_virtual_url);
+ EXPECT_EQ(new_virtual_url, item_->GetVirtualURL());
+ EXPECT_EQ(original_url, item_->GetURL());
+}
+
} // namespace
} // namespace web
« no previous file with comments | « ios/web/navigation/navigation_item_impl.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698