Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 2699003002: Clear cached QUIC network stats when a QUIC handshake fails.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by Ryan Hamilton
Modified:
1 week ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear cached QUIC network stats when a QUIC handshake fails. BUG=

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4 lines) Patch
M net/http/http_server_properties.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/http/http_server_properties_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +11 lines, -0 lines 2 comments Download
M net/http/http_server_properties_manager.h View 3 chunks +5 lines, -1 line 0 comments Download
M net/http/http_server_properties_manager.cc View 1 chunk +10 lines, -0 lines 3 comments Download
M net/http/http_server_properties_manager_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 13 (7 generated)
Ryan Hamilton
1 week, 1 day ago (2017-02-16 23:13:01 UTC) #2
Jana
One clarification question and a nit. https://codereview.chromium.org/2699003002/diff/1/net/http/http_server_properties_impl_unittest.cc File net/http/http_server_properties_impl_unittest.cc (right): https://codereview.chromium.org/2699003002/diff/1/net/http/http_server_properties_impl_unittest.cc#newcode1120 net/http/http_server_properties_impl_unittest.cc:1120: impl_.ClearServerNetworkStats(foo_https_server); Nit: can ...
1 week ago (2017-02-17 02:52:13 UTC) #3
Ryan Hamilton
https://codereview.chromium.org/2699003002/diff/1/net/http/http_server_properties_impl_unittest.cc File net/http/http_server_properties_impl_unittest.cc (right): https://codereview.chromium.org/2699003002/diff/1/net/http/http_server_properties_impl_unittest.cc#newcode1120 net/http/http_server_properties_impl_unittest.cc:1120: impl_.ClearServerNetworkStats(foo_https_server); On 2017/02/17 02:52:12, Jana wrote: > Nit: can ...
1 week ago (2017-02-17 03:41:53 UTC) #4
Jana
lgtm https://codereview.chromium.org/2699003002/diff/1/net/http/http_server_properties_manager.cc File net/http/http_server_properties_manager.cc (right): https://codereview.chromium.org/2699003002/diff/1/net/http/http_server_properties_manager.cc#newcode321 net/http/http_server_properties_manager.cc:321: ScheduleUpdatePrefsOnNetworkThread(CLEAR_SERVER_NETWORK_STATS); On 2017/02/17 03:41:53, Ryan Hamilton wrote: > ...
1 week ago (2017-02-17 05:42:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699003002/1
1 week ago (2017-02-17 15:06:48 UTC) #11
commit-bot: I haz the power
1 week ago (2017-02-17 15:12:49 UTC) #13
Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd