Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Unified Diff: net/http/http_server_properties_manager_unittest.cc

Issue 2699003002: Clear cached QUIC network stats when a QUIC handshake fails. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_server_properties_manager_unittest.cc
diff --git a/net/http/http_server_properties_manager_unittest.cc b/net/http/http_server_properties_manager_unittest.cc
index 0b9fb61c4e89f312bf9060b1956d2a63372d1700..4fbf97e5e1147f88dfb5cc9a564879ad6ff63939 100644
--- a/net/http/http_server_properties_manager_unittest.cc
+++ b/net/http/http_server_properties_manager_unittest.cc
@@ -907,6 +907,24 @@ TEST_P(HttpServerPropertiesManagerTest, ServerNetworkStats) {
const ServerNetworkStats* stats2 =
http_server_props_manager_->GetServerNetworkStats(mail_server);
EXPECT_EQ(10, stats2->srtt.ToInternalValue());
+
+ ExpectPrefsUpdate(1);
+ ExpectScheduleUpdatePrefsOnNetworkThread();
+
+ http_server_props_manager_->ClearServerNetworkStats(mail_server);
+
+ // Run the task.
+ EXPECT_FALSE(pref_test_task_runner_->HasPendingTask());
+ EXPECT_TRUE(net_test_task_runner_->HasPendingTask());
+ net_test_task_runner_->FastForwardUntilNoTasksRemain();
+ EXPECT_TRUE(pref_test_task_runner_->HasPendingTask());
+ pref_test_task_runner_->FastForwardUntilNoTasksRemain();
+ EXPECT_FALSE(net_test_task_runner_->HasPendingTask());
+ EXPECT_FALSE(pref_test_task_runner_->HasPendingTask());
+
+ Mock::VerifyAndClearExpectations(http_server_props_manager_.get());
+ EXPECT_EQ(nullptr,
+ http_server_props_manager_->GetServerNetworkStats(mail_server));
}
TEST_P(HttpServerPropertiesManagerTest, QuicServerInfo) {

Powered by Google App Engine
This is Rietveld 408576698