Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: net/http/http_server_properties_impl_unittest.cc

Issue 2699003002: Clear cached QUIC network stats when a QUIC handshake fails. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_server_properties_impl_unittest.cc
diff --git a/net/http/http_server_properties_impl_unittest.cc b/net/http/http_server_properties_impl_unittest.cc
index ec278578eb2015d6be9a936267346d23b7e97ca0..be611bfb76abda9426278faa3b942b181ffff941 100644
--- a/net/http/http_server_properties_impl_unittest.cc
+++ b/net/http/http_server_properties_impl_unittest.cc
@@ -1110,6 +1110,17 @@ TEST_F(ServerNetworkStatsServerPropertiesTest, SetServerNetworkStats) {
EXPECT_EQ(NULL, impl_.GetServerNetworkStats(foo_https_server));
}
+TEST_F(ServerNetworkStatsServerPropertiesTest, ClearServerNetworkStats) {
+ ServerNetworkStats stats;
+ stats.srtt = base::TimeDelta::FromMicroseconds(10);
+ stats.bandwidth_estimate = QuicBandwidth::FromBitsPerSecond(100);
+ url::SchemeHostPort foo_https_server("https", "foo", 443);
+ impl_.SetServerNetworkStats(foo_https_server, stats);
+
+ impl_.ClearServerNetworkStats(foo_https_server);
Jana 2017/02/17 02:52:12 Nit: can you do a GetServerNetworkStats() before t
Ryan Hamilton 2017/02/17 03:41:53 I can but that's tested in the previous test, and
+ EXPECT_EQ(nullptr, impl_.GetServerNetworkStats(foo_https_server));
+}
+
typedef HttpServerPropertiesImplTest QuicServerInfoServerPropertiesTest;
TEST_F(QuicServerInfoServerPropertiesTest, Set) {

Powered by Google App Engine
This is Rietveld 408576698