Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2698863002: Implement WebGL2's uniform*() with sub source. (Closed)

Created:
3 years, 10 months ago by Zhenyao Mo
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Implement WebGL2's uniform*() with sub source. BUG=688598 TEST=conformance2/uniforms/* R=kbr@chromium.org,kainino@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2692853006 Cr-Commit-Position: refs/heads/master@{#450544} (cherry picked from commit bd3c00a7c7b91c60409cf5d4032c8269c7320c41) Review-Url: https://codereview.chromium.org/2698863002 . Cr-Commit-Position: refs/branch-heads/2987@{#538} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/3a7c59afb439110a3f91f9ad8be724b6e81f9bce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+908 lines, -173 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 chunk +187 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 chunk +558 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 chunk +88 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 26 chunks +60 lines, -54 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhenyao Mo
3 years, 10 months ago (2017-02-16 01:40:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3a7c59afb439110a3f91f9ad8be724b6e81f9bce.

Powered by Google App Engine
This is Rietveld 408576698