Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2692853006: Implement WebGL2's uniform*() with sub source. (Closed)

Created:
3 years, 10 months ago by Zhenyao Mo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, haraken, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement WebGL2's uniform*() with sub source. BUG=688598 TEST=conformance2/uniforms/* R=kbr@chromium.org,kainino@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2692853006 Cr-Commit-Position: refs/heads/master@{#450544} Committed: https://chromium.googlesource.com/chromium/src/+/bd3c00a7c7b91c60409cf5d4032c8269c7320c41

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+908 lines, -173 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 chunk +187 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 chunk +558 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 chunk +88 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 26 chunks +60 lines, -54 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Zhenyao Mo
kbr, kainino: PTAL With this CL, the newly added conformance2/uniforms/* tests pass (without this they ...
3 years, 10 months ago (2017-02-14 18:45:41 UTC) #3
Kai Ninomiya
lgtm
3 years, 10 months ago (2017-02-14 22:41:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692853006/20001
3 years, 10 months ago (2017-02-15 00:57:50 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 01:30:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bd3c00a7c7b91c60409cf5d4032c...

Powered by Google App Engine
This is Rietveld 408576698