Last_n: create snapshots from user triggers even if similar quality ones exist.

Last_n: create snapshots from user triggers even if similar quality ones exist.

With this change when a tab-hidden event happens a last_n snapshot will
be created even if one already exists with the same expected quality
level. This should fix cases of very dynamic pagesnot being properly
saved, where contents are completely changed without clear navigation or
loading events being triggered.

This also re-introduces the ignoring of same-page navigations when
listening to DidFinishNavigation so that we don't reset the loading
state of the page in those cases.

BUG=691506, 678367
Review-Url: https://codereview.chromium.org/2698713002
Cr-Commit-Position: refs/heads/master@{#451819}
Committed: https://chromium.googlesource.com/chromium/src/+/f0b30fafe9d73f73c430895d289ab83c3e818d20

[carlosk, 2017-02-15 19:18:38]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 19:19:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[carlosk, 2017-02-15 19:19:22]

carlosk@chromium.org changed reviewers:
+ dimich@chromium.org

[carlosk, 2017-02-15 19:19:23]

dimich@: PTAL.

[Dmitry Titov, 2017-02-15 19:26:44]

lgtm

[commit-bot: I haz the power, 2017-02-15 20:30:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 20:30:18]

Dry run: This issue passed the CQ dry run.

[carlosk, 2017-02-15 21:53:07]

dimich@ could you PTA(nother)L?

I had to change the way we store and record the page URL. Now it always uses the
current URL from the WebContests instead of whatever was recorded in the last
navigation we did not ignore.

As same-page navigations are ignored and they could change the URL, we were
hitting the previous DCHECK. This change should in fact make our offline page
URLs saner.

[carlosk, 2017-02-15 21:53:26]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 21:54:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 23:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 23:34:43]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[carlosk, 2017-02-16 18:58:27]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 18:59:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 19:39:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 19:39:15]

Dry run: This issue passed the CQ dry run.

[Dmitry Titov, 2017-02-17 23:34:09]

Still lgtm

[carlosk, 2017-02-17 23:48:08]

The CQ bit was checked by carlosk@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:49:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:54:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:54:51]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[carlosk, 2017-02-21 18:17:22]

The CQ bit was checked by carlosk@chromium.org

[carlosk, 2017-02-21 18:17:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dimich@chromium.org
Link to the patchset: https://codereview.chromium.org/2698713002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-02-21 18:18:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 19:37:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487701042278560,
"parent_rev": "47722dd6d68e52093d7f75f83d36a9fa011ede88", "commit_rev":
"f0b30fafe9d73f73c430895d289ab83c3e818d20"}

[commit-bot: I haz the power, 2017-02-21 19:37:53]

Description was changed from

==========
Last_n: create snapshots from user triggers even if similar quality ones exist.

With this change when a tab-hidden event happens a last_n snapshot will
be created even if one already exists with the same expected quality
level. This should fix cases of very dynamic pagesnot being properly
saved, where contents are completely changed without clear navigation or
loading events being triggered.

This also re-introduces the ignoring of same-page navigations when
listening to DidFinishNavigation so that we don't reset the loading
state of the page in those cases.

BUG=691506,678367
==========

to

==========
Last_n: create snapshots from user triggers even if similar quality ones exist.

With this change when a tab-hidden event happens a last_n snapshot will
be created even if one already exists with the same expected quality
level. This should fix cases of very dynamic pagesnot being properly
saved, where contents are completely changed without clear navigation or
loading events being triggered.

This also re-introduces the ignoring of same-page navigations when
listening to DidFinishNavigation so that we don't reset the loading
state of the page in those cases.

BUG=691506,678367

Review-Url: https://codereview.chromium.org/2698713002
Cr-Commit-Position: refs/heads/master@{#451819}
Committed:
https://chromium.googlesource.com/chromium/src/+/f0b30fafe9d73f73c430895d289a...
==========

[commit-bot: I haz the power, 2017-02-21 19:37:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f0b30fafe9d73f73c430895d289a...