Last_n: create snapshots from user triggers even if similar quality ones exist.

chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/recent_tab_helper.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 726 matching lines @@
   EXPECT_EQ(download_client_id, downloads_page->client_id);
 
   const OfflinePageItem& last_n_page =
       GetAllPages()[0].offline_id != download_offline_id ? GetAllPages()[0]
                                                          : GetAllPages()[1];
   EXPECT_EQ(kTestPageUrl, last_n_page.url);
   EXPECT_EQ(kLastNNamespace, last_n_page.client_id.name_space);
 }
 
 // Simulates multiple tab hidden events -- triggers for last_n snapshots --
-// happening at the same loading stages. The duplicate events should not cause
-// new snapshots to be saved.
-TEST_F(RecentTabHelperTest, DuplicateTabHiddenEventsShouldNotTriggerSnapshots) {
+// happening at the same loading stages. The duplicate events should create new
+// snapshots (so that dynamic pages are properly persisted; navigation/loading
+// signals are poor signals for those).
+TEST_F(RecentTabHelperTest, DuplicateTabHiddenEventsShouldTriggerNewSnapshots) {
   NavigateAndCommit(kTestPageUrl);
   recent_tab_helper()->DocumentAvailableInMainFrame();
   FastForwardSnapshotController();
   recent_tab_helper()->WasHidden();
   RunUntilIdle();
   EXPECT_EQ(1U, page_added_count());
   EXPECT_EQ(0U, model_removed_count());
   ASSERT_EQ(1U, GetAllPages().size());
 
   recent_tab_helper()->WasHidden();
   RunUntilIdle();
-  EXPECT_EQ(1U, page_added_count());
-  EXPECT_EQ(0U, model_removed_count());
+  EXPECT_EQ(2U, page_added_count());
+  EXPECT_EQ(1U, model_removed_count());
   ASSERT_EQ(1U, GetAllPages().size());
 
   recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
   FastForwardSnapshotController();
   recent_tab_helper()->WasHidden();
   RunUntilIdle();
-  EXPECT_EQ(2U, page_added_count());
-  EXPECT_EQ(1U, model_removed_count());
+  EXPECT_EQ(3U, page_added_count());
+  EXPECT_EQ(2U, model_removed_count());
   ASSERT_EQ(1U, GetAllPages().size());
 
   recent_tab_helper()->WasHidden();
   RunUntilIdle();
-  EXPECT_EQ(2U, page_added_count());
-  EXPECT_EQ(1U, model_removed_count());
+  EXPECT_EQ(4U, page_added_count());
+  EXPECT_EQ(3U, model_removed_count());
   ASSERT_EQ(1U, GetAllPages().size());
 }
 
 // Simulates multiple download requests and verifies that overlapping requests
 // are ignored.
 TEST_F(RecentTabHelperTest, OverlappingDownloadRequestsAreIgnored) {
   // Navigates and commits then make two download snapshot requests.
   NavigateAndCommit(kTestPageUrl);
   const ClientId client_id_1 = NewDownloadClientId();
   const int64_t offline_id_1 = 153L;
@@ skipping 22 matching lines @@
   RunUntilIdle();
   EXPECT_EQ(2U, page_added_count());
   EXPECT_EQ(0U, model_removed_count());
   ASSERT_EQ(2U, GetAllPages().size());
   const OfflinePageItem* second_page = FindPageForOfflineId(offline_id_3);
   ASSERT_TRUE(second_page);
   EXPECT_EQ(client_id_3, second_page->client_id);
   EXPECT_EQ(offline_id_3, second_page->offline_id);
 }
 
+// Simulates a same page navigation and checks we snapshot correctly with last_n
+// and downloads.
+TEST_F(RecentTabHelperTest, SaveSamePageNavigationSnapshots) {
+  // Navigates and load fully then hide the tab so that a snapshot is created.
+  NavigateAndCommit(kTestPageUrl);
+  recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
+  FastForwardSnapshotController();
+  recent_tab_helper()->WasHidden();
+  RunUntilIdle();
+  EXPECT_EQ(1U, page_added_count());
+  EXPECT_EQ(0U, model_removed_count());
+  ASSERT_EQ(1U, GetAllPages().size());
+
+  // Now navigates same page and check the results of hiding the tab again.
+  // Another snapshot should be created to the updated URL.
+  const GURL kTestPageUrlWithSegment(kTestPageUrl.spec() + "#aaa");
+  NavigateAndCommit(kTestPageUrlWithSegment);
+  recent_tab_helper()->WasHidden();
+  RunUntilIdle();
+  EXPECT_EQ(2U, page_added_count());
+  EXPECT_EQ(1U, model_removed_count());
+  ASSERT_EQ(1U, GetAllPages().size());
+  EXPECT_EQ(kTestPageUrlWithSegment, GetAllPages()[0].url);
+
+  // Now create a download request and check the snapshot is properly created.
+  const ClientId client_id = NewDownloadClientId();
+  const int64_t offline_id = 153L;
+  recent_tab_helper()->ObserveAndDownloadCurrentPage(client_id, offline_id);
+  RunUntilIdle();
+  EXPECT_EQ(3U, page_added_count());
+  EXPECT_EQ(1U, model_removed_count());
+  ASSERT_EQ(2U, GetAllPages().size());
+  const OfflinePageItem* downloads_page = FindPageForOfflineId(offline_id);
+  EXPECT_EQ(kTestPageUrlWithSegment, downloads_page->url);
+  EXPECT_EQ(client_id, downloads_page->client_id);
+  EXPECT_EQ(offline_id, downloads_page->offline_id);
+}
+
 }  // namespace offline_pages