Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.h

Issue 2698713002: Last_n: create snapshots from user triggers even if similar quality ones exist. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/recent_tab_helper.h
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.h b/chrome/browser/android/offline_pages/recent_tab_helper.h
index d1bbf5b7bde068da6865b79245da0ca31bf7b01f..50a3cda30a7d4b05c1d01307e0f37ae044768461 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.h
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.h
@@ -133,10 +133,6 @@ class RecentTabHelper
// If empty, the tab does not have AndroidId and can not capture pages.
std::string tab_id_;
- // The URL of the page that is currently being snapshotted. Used to check,
- // during async operations, that WebContents still contains the same page.
- GURL snapshot_url_;
-
// Monitors page loads and starts snapshots when a download request exist. It
// is also used as an initialization flag for EnsureInitialized() to be run
// only once.
@@ -148,11 +144,6 @@ class RecentTabHelper
// current page being loaded.
bool last_n_listen_to_tab_hidden_ = false;
- // Track the page quality status of the last saved snapshot for the current
- // page. It is generally reset upon new navigations.
- SnapshotController::PageQuality last_n_latest_saved_quality_ =
- SnapshotController::PageQuality::POOR;
-
base::WeakPtrFactory<RecentTabHelper> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(RecentTabHelper);
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698